Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using .less files instead of .css files for default #3

Closed
scottmas opened this issue May 19, 2017 · 3 comments
Closed

Consider using .less files instead of .css files for default #3

scottmas opened this issue May 19, 2017 · 3 comments

Comments

@scottmas
Copy link

scottmas commented May 19, 2017

Nice work! It gives me shivers of happiness to see that 20kb download size for a fully functional app.

However, I just barely ran preact create my-test-app and it doesn't come with built in LESS support, just boring old .css files. Or is there a config to use LESS? Do you need to bump the NPM version? Since I see in your examples folder that LESS should be supported.

@scottmas scottmas changed the title Bump NPM version? Less support not enabled by default Bump NPM version? LESS support not enabled by default May 19, 2017
@scottmas scottmas changed the title Bump NPM version? LESS support not enabled by default Consider using .less files instead of .css files for default May 19, 2017
@scottmas
Copy link
Author

My mistake. LESS files build just fine if you just change the extension.

May be worth considering generating .less files by default though.

Although I know there is quite a bit of precedent for doing CSS files by default (React Create App, Angular CLI), I think that's the wrong decision. Lots of developers won't even know the CLI supports a CSS preprocessor, and rather than figure out that they can use a preprocessor, they just forge onward with raw css. This has actually happened to me before in an Angular CLI project I inherited.

Less is pretty widely understood, and I just can't imagine any developer in their right mind wanting to write raw css.

@developit
Copy link
Member

FWIW I'm a less user as well, but I don't want to push it on anyone. I can't remember if we have it in yet, but there is supposed to be a --less option in create that sets less up as the default. Same for sass.

@scottmas
Copy link
Author

Good point. Documenting the flags on create probably is a better option. Is a better forward path for supporting sass or postcss.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants