Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add description of install and no-install options. #204

Merged
merged 1 commit into from
Jul 7, 2017

Conversation

knight-bubble
Copy link
Contributor

Added two missing options for the create command, changed formatting.

README.md Outdated
--sass Pre-install SASS/SCSS support. [boolean] [default: false]
--stylus Pre-install STYLUS support. [boolean] [default: false]
--git Initialize version control using git. [boolean] [default: true]
--install Install dependencies. [boolean] [default: true]
Copy link
Member

@reznord reznord Jul 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--install is not required since by default we will be installing dependencies. Please remove this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So basically we shouldn't be able to do

preact create appname --install=false

Right?
And instead

preact create appname--no-install

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is preact create my_app --no-install, with this, it will just simply initialise the project but will not install node_modules.

@knight-bubble knight-bubble force-pushed the update-readme-with-install branch from 22d974d to 855df6b Compare July 7, 2017 17:48
@reznord reznord merged commit 4c1fd35 into preactjs:master Jul 7, 2017
@developit
Copy link
Member

Might want to stick with --install default:true - already fielding questions about --no-install haha

--sass Pre-install SASS/SCSS support. [boolean] [default: false]
--stylus Pre-install STYLUS support. [boolean] [default: false]
--git Initialize version control using git. [boolean] [default: true]
--no-install Disables installing of dependensies. [boolean] [default: false]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

y does this need a [boolean] [default: false]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah right !! Will change it (there are a couple of things to change too)

@reznord
Copy link
Member

reznord commented Jul 10, 2017

Might want to stick with --install default:true

what is the point of adding that, since the default functionality is that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants