-
-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add description of install and no-install options. #204
Add description of install and no-install options. #204
Conversation
README.md
Outdated
--sass Pre-install SASS/SCSS support. [boolean] [default: false] | ||
--stylus Pre-install STYLUS support. [boolean] [default: false] | ||
--git Initialize version control using git. [boolean] [default: true] | ||
--install Install dependencies. [boolean] [default: true] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--install
is not required since by default we will be installing dependencies. Please remove this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So basically we shouldn't be able to do
preact create appname --install=false
Right?
And instead
preact create appname--no-install
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it is preact create my_app --no-install
, with this, it will just simply initialise the project but will not install node_modules.
22d974d
to
855df6b
Compare
Might want to stick with |
--sass Pre-install SASS/SCSS support. [boolean] [default: false] | ||
--stylus Pre-install STYLUS support. [boolean] [default: false] | ||
--git Initialize version control using git. [boolean] [default: true] | ||
--no-install Disables installing of dependensies. [boolean] [default: false] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
y does this need a [boolean] [default: false]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah right !! Will change it (there are a couple of things to change too)
what is the point of adding that, since the default functionality is that |
Added two missing options for the create command, changed formatting.