Skip to content

Commit

Permalink
support data attribute (#289)
Browse files Browse the repository at this point in the history
  • Loading branch information
JoviDeCroock authored Mar 27, 2023
1 parent 6376f62 commit 07ebc66
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 4 deletions.
5 changes: 5 additions & 0 deletions .changeset/perfect-ducks-rule.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'preact-render-to-string': patch
---

Support `data` attribute
5 changes: 1 addition & 4 deletions src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -311,10 +311,7 @@ function _renderToString(vnode, context, isSvgMode, selectValue, parent) {
name = name.toLowerCase().replace(XLINK_REPLACE_REGEX, 'xlink:');
} else if (UNSAFE_NAME.test(name)) {
continue;
} else if (
((name[0] === 'a' && name[1] === 'r') || name === 'draggable') &&
v != null
) {
} else if ((name[4] === '-' || name === 'draggable') && v != null) {
// serialize boolean aria-xyz or draggable attribute values as strings
// `draggable` is an enumerated attribute and not Boolean. A value of `true` or `false` is mandatory
// https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/draggable
Expand Down
10 changes: 10 additions & 0 deletions test/render.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,16 @@ describe('render', () => {
expect(rendered).to.equal(expected);
});

it('should support false aria-* attributes', () => {
let rendered = render(<div aria-checked={false} />);
expect(rendered).to.equal(`<div aria-checked="false"></div>`);
});

it('should support false data-* attributes', () => {
let rendered = render(<div data-checked={false} />);
expect(rendered).to.equal(`<div data-checked="false"></div>`);
});

describe('attribute name sanitization', () => {
it('should omit attributes with invalid names', () => {
let rendered = render(
Expand Down

0 comments on commit 07ebc66

Please sign in to comment.