Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stackoverflow when running pixi in debug mode on windows #2922

Merged

Conversation

baszalmstra
Copy link
Contributor

I'm still running into stack overflow issues when running pixi in debug mode on windows. This is mostly caused by the fact that windows has a 1MB stack size for the main thread. Which is relatively small to the 8MB on macOS and Linux.

Apparently, there is a not very well-documented environment variable to set the stack size of threads called RUST_MIN_STACK. But this only sets the stack-size for newly spawned threads while the issues happens on the main thread. I noticed uv very recently worked around this issue to spawn an additional main thread from which the entire application is ran. Pretty clever, so I implemented the same behavior for pixi.

Now I can finally run pixi again in debug mode. 🥳

Copy link
Contributor

@Hofer-Julian Hofer-Julian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Annoying that this is necessary, but great that this let's debug builds work again on Windows 🥳

@Hofer-Julian Hofer-Julian merged commit b201584 into prefix-dev:main Jan 16, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants