Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: will also update prefix if there are pypi path dependencies #3034

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

tdejager
Copy link
Contributor

Attempt to implement: #1881 (comment)

This will also update the prefix on run when there are pypi path dependencies that are directories, this will typically be source files that we are working with. I think this is in spirit with the wanted behavior, even though the conda filter works a bit differently, as I expect git dependencies to be updated with a pixi update instead. And path dependencies which are not directories are either wheels or sdists, and do not change often (if at all)

How to test?

pixi init --format=pyproject
#should do a full install
pixi r python
touch pyproject.toml
# should update the prefix (does not happen on main)
pixi r python

Copy link
Contributor

@ruben-arts ruben-arts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks that indeed fixed it!

@ruben-arts ruben-arts merged commit 35f3ddb into prefix-dev:main Jan 30, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants