fix: manually exposed executables are removed after pixi global update
#3109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nichmor
approved these changes
Feb 12, 2025
| @@ -662,8 +662,22 @@ impl Project { | |||
| Ok(state_changes) | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Suggested change
| /// Get all installed executables of all dependencies of a specific environment. |
src/global/project/mod.rs
Outdated
| @@ -662,8 +662,22 @@ impl Project { | |||
| Ok(state_changes) | |||
| } | |||
|
|
|||
| /// Get all installed executables for specific environment. | |||
| pub async fn executables( | |||
| pub async fn executables_all_dependencies( | |||
There was a problem hiding this comment.
sorry if it's nitpicking
maybe we can name it
pub async fn executables_from_all_dependencies
and
pub async fn executables_from_direct_dependencies
?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3014
ExposedTypelogic since there were a few incorrect assumptions