Skip to content

Commit

Permalink
Disable KllSketch memory test for strings
Browse files Browse the repository at this point in the history
It seems later JVMs have drasitically improved their String
representations. However, the string test is a bit of a wash
because the estimated size entirely depends upon the
strings which are used as input to the sketch. I think it's
ok for this test to not be accurate for string-typed
arguments for now.
  • Loading branch information
ZacBlanco authored and aaneja committed Feb 27, 2025
1 parent 1513050 commit 683fc07
Showing 1 changed file with 2 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
import org.apache.datasketches.common.ArrayOfStringsSerDe;
import org.apache.datasketches.kll.KllItemsSketch;
import org.openjdk.jol.info.GraphLayout;
import org.testng.annotations.Ignore;
import org.testng.annotations.Test;

import java.util.Arrays;
Expand Down Expand Up @@ -91,6 +92,7 @@ public void testEstimatedMemorySizeLong()
testEstimatedMemorySize(BIGINT, i -> (long) i, .05);
}

@Ignore("The memory size of a string-typed sketch is dependent upon the strings used as input, so this test doesn't verify much")
@Test
public void testEstimatedMemorySizeString()
{
Expand Down

0 comments on commit 683fc07

Please sign in to comment.