Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Row Grouping is not working as expected #1830

Closed
smedavarapu opened this issue Jan 18, 2017 · 1 comment
Closed

Row Grouping is not working as expected #1830

smedavarapu opened this issue Jan 18, 2017 · 1 comment
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@smedavarapu
Copy link

I'm submitting a ... (check one with "x")

[x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Plunkr Case (Bug Reports)
http://plnkr.co/edit/YvhroNjH0A9WkZUMy4kc?p=preview

Current behavior
Throws find of undefined error when rows are grouped by rowspan.

Taking a look at the source code of datatable.ts, seemed to be initializing the columns in ngAfterContentInit. But, 'this.columns.find' is executed in ngDoCheck, the step before the content is initialized.

Expected behavior
Rows must be grouped on groupField

Minimal reproduction of the problem with instructions

http://plnkr.co/edit/YvhroNjH0A9WkZUMy4kc?p=preview

when groupField, sortField and rowGroupMode are passed to p-dataTable, the entire table breaks. It throws 'Cannot read property 'find' of undefined' in the console.

What is the motivation / use case for changing the behavior?
Row Grouping on the Table

Please tell us about your environment:
Win 10, VS2015, NPM, Asp.Net Core RTM

  • Angular version: 2.0.0

  • PrimeNG version: 1.1.1/1.1.4

  • Browser: Chrome, Firefox, Edge

  • Language: TypeScript 2.0

  • Node (for AoT issues): node --version = v4.2.5

@cagataycivici cagataycivici added Status: Pending Review Issue or pull request is being reviewed by Core Team Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Jun 19, 2017
brpradeepprabhu added a commit to brpradeepprabhu/primeng that referenced this issue Jul 1, 2017
@cagataycivici cagataycivici self-assigned this Aug 10, 2017
@cagataycivici cagataycivici added this to the 4.1.3 milestone Aug 10, 2017
@cagataycivici
Copy link
Member

Can't replicate with 4.1, please provide a plunkr based on;

http://plnkr.co/edit/Qi2Nw2imLpDUF8NJinYw?p=preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants