Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that document functions exist before calling in ngOnDestroy() #2327

Closed
cagataycivici opened this issue Mar 17, 2017 · 2 comments
Closed

Ensure that document functions exist before calling in ngOnDestroy() #2327

cagataycivici opened this issue Mar 17, 2017 · 2 comments
Assignees
@cagataycivici
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
2.0.4

Comments

@cagataycivici
Copy link
Member

Issue #1672 fixed a number of problems, but several components seem to have been left out of that set of fixes. These listener calls also need checks to ensure that the listeners exist before they are called during destroy:

primeng/components/confirmdialog/confirmdialog.ts

Line 223 in f512363

if(this.responsive) {

primeng/components/confirmdialog/confirmdialog.ts

Line 227 in f512363

if(this.closeOnEscape && this.closable) {

primeng/components/carousel/carousel.ts

Line 308 in b16e346

if(this.responsive) {

primeng/components/contextmenu/contextmenu.ts

Line 241 in 2ce2f97

this.documentClickListener();

primeng/components/contextmenu/contextmenu.ts

Line 243 in 2ce2f97

if(this.global) {

@cagataycivici cagataycivici self-assigned this Mar 17, 2017
@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Mar 17, 2017
@cagataycivici cagataycivici added this to the 2.0.4 milestone Mar 17, 2017
cagataycivici pushed a commit that referenced this issue Mar 17, 2017
Fixed #2327 for 2.0.4
399e7b6
@andrii-oleksyshyn
Copy link

399e7b6 doesn't contain fix for the context menu component

@cagataycivici
Copy link
Member Author

Please see;

#2349

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cagataycivici cagataycivici

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
2.0.4
Development

No branches or pull requests
2 participants
@cagataycivici @andrii-oleksyshyn