Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Udate moment version to 2.19.3 or newer #5926

Closed
peterblazejewicz opened this issue Jun 16, 2018 · 0 comments
Closed

Udate moment version to 2.19.3 or newer #5926

peterblazejewicz opened this issue Jun 16, 2018 · 0 comments
Assignees
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@peterblazejewicz
Copy link

I'm submitting a ...

[x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

The moment (Moment.js) library used in project needs simple update to the next version with security vulnerability patched
https://nodesecurity.io/advisories?search=moment&version=2.18.1

Current behavior
n/a

Expected behavior
n/a

Minimal reproduction of the problem with instructions

git clone  https://github.com/primefaces/primeng.git
cd primeng
npm install

WARN notice [SECURITY] moment has the following vulnerability: 1 low. Go here for more details: https://nodesecurity.io/advisories?search=moment&version=2.18.1 - Run npm i npm@latest -g to upgrade your npm version, and then npm audit to get more info.

What is the motivation / use case for changing the behavior?
Update moment version to the recommended version

Please tell us about your environment:
n/a

  • Angular version: 5.X
    n/a

  • PrimeNG version: 5.X
    n/a
    development: 6.0.0-SNAPSHOT

  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
    n/a

  • Language: [all | TypeScript X.X | ES6/7 | ES5]
    n/a

  • Node (for AoT issues): node --version =
    n/a

peterblazejewicz added a commit to peterblazejewicz/primeng that referenced this issue Jun 16, 2018
This fixes vulnerability warnings during libary install

Thanks!
@cagataycivici cagataycivici self-assigned this Jul 11, 2018
@cagataycivici cagataycivici added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Jul 11, 2018
@cagataycivici cagataycivici added this to the 6.0.1 milestone Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

2 participants