Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Down arrow press on draggable Tree #7617

Closed
EcoFreak opened this issue May 1, 2019 · 0 comments
Closed

Down arrow press on draggable Tree #7617

EcoFreak opened this issue May 1, 2019 · 0 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@EcoFreak
Copy link

EcoFreak commented May 1, 2019

I'm submitting a bug.

[ ] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Current behavior
When using a tree with drag/drop, the down key does not focus the children nodes but instead focus the next sibling node.

Expected behavior
The down key should focus the children nodes if they are present. This behavior occurs when the tree does not have drag/drop feature activated.

Minimal reproduction of the problem with instructions
Using the primeng tree compoment documentation the issue is reproducable.
https://www.primefaces.org/primeng/#/tree

Down keypress on first example tree works ok (when focusing a parent node and pressing down, the first child is focused).

DragDrop key does not work ok. (when focusing a parent node and pressing down, the next sibling is focused).

I think this is an easy fix.
According to the onKeyDown function the code that handles the down arrow (40) does not check the droppableNodes property.

@cagataycivici cagataycivici self-assigned this May 10, 2019
@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label May 10, 2019
@cagataycivici cagataycivici added this to the 7.1.3 milestone May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants