Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

focusZone: Add support for Backspace key #155

Merged
merged 2 commits into from
Oct 27, 2022
Merged

focusZone: Add support for Backspace key #155

merged 2 commits into from
Oct 27, 2022

Conversation

colebemis
Copy link
Contributor

Context

From @jscholes in the TreeView a11y sign-off:

On Windows, the Backspace key has an expected function in tree views. It mostly performs the same purpose as Left Arrow, but with an important distinction: it does not collapse nodes.

Summary

This PR adds Backspace to the list of FocusKeys so we can support the Backspace behavior @jscholes described in TreeView.

@colebemis colebemis requested review from a team and siddharthkp October 27, 2022 17:41
@changeset-bot
Copy link

changeset-bot bot commented Oct 27, 2022

🦋 Changeset detected

Latest commit: b14b5ac

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/behaviors Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@colebemis colebemis requested a review from joshblack October 27, 2022 18:21
Copy link
Member

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🔥

@colebemis colebemis merged commit 232a596 into main Oct 27, 2022
@colebemis colebemis deleted the backspace branch October 27, 2022 20:19
@primer-css primer-css mentioned this pull request Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants