[FocusZone] Clear all active descendants #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ee1e19d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
camertron
force-pushed
the
clear_all_descendants
branch
from
dfb7f87 to
27df1d6
Compare
camertron
requested review from
joshblack and
dgreif
and removed request for
joshblack
dgreif
approved these changes
Oct 18, 2024
… in case it's no longer in the DOM
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes several changes to focus-zone:
signalto several event listeners where it is currently missing.clearActiveDescendantto loop over all child elements with thedata-is-active-descendantattribute and removes it from each. The current behavior only removes the attribute from a single element, which is a problem in React apps because React re-uses elements with the same key, resulting in more than one element being marked as the active descendant.