Au tocomplete var #1188
Merged
Au tocomplete var #1188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To reuse in other components
Changes to - Dropdowns - Popovers - Select-menus
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/primer-css/xx567y45s |
|
Ok, updated this PR with the changes from primitives and also added a hack for the |
simurai
added a commit
to primer/primitives
that referenced
this pull request
Nov 2, 2020
That got replaced with primer/css#1188
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes from component-level variables to new gloval ones created in this PR
📁 dropdown
📁 autocomplete
📁 popovers
📁 select-menu
Noticed 2 more variables that can be globalized.
From:
var(--color-dropdown-shadow)var(--color-autocomplete-shadow)var(--color-select-menu-shadow)To:
var(--color-overlay-shadowNoticed there isn't a shadow property for
.Popover- is this because it gets used with.Box?Needs testing and for the primitives PR to be merged before.