Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release Tracking #2392

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Release Tracking #2392

merged 1 commit into from
Mar 31, 2023

Conversation

primer-css
Copy link
Contributor

@primer-css primer-css commented Feb 28, 2023 •
edited
Loading

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

@primer/[email protected]

Major Changes

  • #2403 256affcf Thanks @lukasoppermann! - ## Removed DiffStat component

    • the diffStat component is removed from primer/css
    • the component is very specific to this use-case, it is not generic enough to be part of the primer design system and was thus chosen for removal
    • the component will be added to the github codebase directly so that it is still available
    • if you are working within github.com you should be ale to use diffStat just like before. On other projects you will need to copy the diffStat code and add it to your codebase

  • #2402 c6e214b7 Thanks @simurai! - Remove form-validation styles

  • #2405 85f31cc8 Thanks @simurai! - Remove ActionList

Patch Changes

@primer-css primer-css requested a review from a team as a code owner February 28, 2023 06:01
@primer-css primer-css requested a review from simurai February 28, 2023 06:01
@github-actions
Copy link
Contributor

github-actions bot commented Feb 28, 2023 •
edited by simurai
Loading

Preparing for a release.

Checklist

Make sure these items are checked before merging.

  • Preview the docs change.
  • Preview npm release candidate.
  • CI passes on the release PR.

Selectors added/removed since latest release

--- before.txt	2023-03-30 12:58:27.278030531 +0000
+++ after.txt	2023-03-30 12:58:27.334030570 +0000
@@ -3,139 +3,2 @@
 *:focus-visible
-.ActionList
-.ActionList--divided .ActionList-item--navActive .ActionList-item-label::before
-.ActionList--divided .ActionList-item--navActive+.ActionList-item .ActionList-item-label::before
-.ActionList--divided .ActionList-item-descriptionWrap--inline .ActionList-item-label::before
-.ActionList--divided .ActionList-item-descriptionWrap--inline::before
-.ActionList--divided .ActionList-item-label::before
-.ActionList--full
-.ActionList--subGroup
-.ActionList--tree
-.ActionList--tree .ActionList-content[aria-expanded=false] .ActionList-item-collapseIcon
-.ActionList--tree .ActionList-content[aria-expanded=false].ActionList-content--hasActiveSubItem>.ActionList-item-label
-.ActionList--tree .ActionList-content[aria-expanded=true] .ActionList-item-collapseIcon
-.ActionList--tree .ActionList-content[aria-expanded=true].ActionList-content--hasActiveSubItem>.ActionList-item-label
-.ActionList--tree .ActionList-content[aria-expanded]+.ActionList--subGroup
-.ActionList--tree .ActionList-content[aria-expanded]+.ActionList--subGroup .ActionList-content
-.ActionList--tree .ActionList-item--hasSubItem .ActionList-item--subItem:not(.ActionList-item--hasSubItem) .ActionList-content>span:first-child
-.ActionList--tree .ActionList-item--hasSubItem:not([aria-level="1"])>.ActionList--subGroup::before
-.ActionList--tree .ActionList-item--subItem>.ActionList-content
-.ActionList--tree .ActionList-item.ActionList-item--navActive:not(.ActionList-item--subItem) .ActionList-item-label
-.ActionList--tree .ActionList-item.ActionList-item--singleton .ActionList-content
-.ActionList--tree>[aria-level="1"].ActionList-item--hasSubItem>.ActionList--subGroup::before
-.ActionList-content
-.ActionList-content.ActionList-content--blockDescription .ActionList-item-visual
-.ActionList-content.ActionList-content--fontSmall
-.ActionList-content.ActionList-content--sizeLarge
-.ActionList-content.ActionList-content--sizeMedium
-.ActionList-content:focus
-.ActionList-content:focus-visible
-.ActionList-content:focus:not(:focus-visible)
-.ActionList-content:hover
-.ActionList-content>:not(:last-child)
-.ActionList-content[aria-disabled=true] .ActionList-item-description
-.ActionList-content[aria-disabled=true] .ActionList-item-label
-.ActionList-content[aria-disabled=true] .ActionList-item-visual
-.ActionList-content[aria-disabled=true]:hover
-.ActionList-content[aria-expanded=false] .ActionList-item-collapseIcon
-.ActionList-content[aria-expanded=false]+.ActionList--subGroup
-.ActionList-content[aria-expanded=false].ActionList-content--hasActiveSubItem
-.ActionList-content[aria-expanded=false].ActionList-content--hasActiveSubItem .ActionList-item-label
-.ActionList-content[aria-expanded=false].ActionList-content--hasActiveSubItem+.ActionList-item::before
-.ActionList-content[aria-expanded=false].ActionList-content--hasActiveSubItem::after
-.ActionList-content[aria-expanded=false].ActionList-content--hasActiveSubItem::before
-.ActionList-content[aria-expanded=true] .ActionList-item-collapseIcon
-.ActionList-content[aria-expanded=true]+.ActionList--subGroup
-.ActionList-content[aria-expanded=true].ActionList-content--hasActiveSubItem>.ActionList-item-label
-.ActionList-content[aria-expanded]+.ActionList--subGroup
-.ActionList-content[aria-expanded]+.ActionList--subGroup .ActionList-content
-.ActionList-content[aria-expanded].ActionList-content--visual16+.ActionList--subGroup .ActionList-content
-.ActionList-content[aria-expanded].ActionList-content--visual20+.ActionList--subGroup .ActionList-content
-.ActionList-content[aria-expanded].ActionList-content--visual24+.ActionList--subGroup .ActionList-content
-.ActionList-item
-.ActionList-item .ActionList
-.ActionList-item--subItem>.ActionList-content
-.ActionList-item-action
-.ActionList-item-action--leading
-.ActionList-item-action--trailing
-.ActionList-item-description
-.ActionList-item-descriptionWrap
-.ActionList-item-descriptionWrap .ActionList-item-description
-.ActionList-item-descriptionWrap .ActionList-item-label
-.ActionList-item-descriptionWrap--inline
-.ActionList-item-descriptionWrap--inline .ActionList-item-description
-.ActionList-item-label
-.ActionList-item-label--truncate
-.ActionList-item-visual
-.ActionList-item-visual--leading
-.ActionList-item-visual--trailing
-.ActionList-item.ActionList-item--danger .ActionList-content:active
-.ActionList-item.ActionList-item--danger .ActionList-item-label
-.ActionList-item.ActionList-item--danger .ActionList-item-visual
-.ActionList-item.ActionList-item--danger:hover
-.ActionList-item.ActionList-item--danger:hover .ActionList-item-label
-.ActionList-item.ActionList-item--hasSubItem>.ActionList-content
-.ActionList-item.ActionList-item--hasSubItem>.ActionList-content:active
-.ActionList-item.ActionList-item--hasSubItem>.ActionList-content:active .ActionList-item-label::before
-.ActionList-item.ActionList-item--hasSubItem>.ActionList-content:active+.ActionList-item .ActionList-item-label::before
-.ActionList-item.ActionList-item--hasSubItem>.ActionList-content:active:not(.ActionList-item--navActive)
-.ActionList-item.ActionList-item--hasSubItem>.ActionList-content:hover
-.ActionList-item.ActionList-item--hasSubItem>.ActionList-content:hover .ActionList-item-descriptionWrap--inline::before
-.ActionList-item.ActionList-item--hasSubItem>.ActionList-content:hover .ActionList-item-label::before
-.ActionList-item.ActionList-item--hasSubItem>.ActionList-content:hover+.ActionList-item .ActionList-item-descriptionWrap--inline::before
-.ActionList-item.ActionList-item--hasSubItem>.ActionList-content:hover+.ActionList-item .ActionList-item-label::before
-.ActionList-item.ActionList-item--hasSubItem>.ActionList-content:hover:not(.ActionList-item--navActive):not(:focus-visible)
-.ActionList-item.ActionList-item--navActive:not(.ActionList-item--danger)
-.ActionList-item.ActionList-item--navActive:not(.ActionList-item--danger)+.ActionList-item::before
-.ActionList-item.ActionList-item--navActive:not(.ActionList-item--danger)::after
-.ActionList-item.ActionList-item--navActive:not(.ActionList-item--danger)::before
-.ActionList-item.ActionList-item--navActive:not(.ActionList-item--danger):hover
-.ActionList-item.ActionList-item--navActive:not(.ActionList-item--subItem) .ActionList-item-label
-.ActionList-item:active
-.ActionList-item:first-of-type .ActionList-item-descriptionWrap--inline::before
-.ActionList-item:first-of-type .ActionList-item-label::before
-.ActionList-item:hover
-.ActionList-item:not(.ActionList-item--hasSubItem):active
-.ActionList-item:not(.ActionList-item--hasSubItem):active .ActionList-item-label::before
-.ActionList-item:not(.ActionList-item--hasSubItem):active+.ActionList-item .ActionList-item-label::before
-.ActionList-item:not(.ActionList-item--hasSubItem):active:not(.ActionList-item--navActive)
-.ActionList-item:not(.ActionList-item--hasSubItem):hover
-.ActionList-item:not(.ActionList-item--hasSubItem):hover .ActionList-item-descriptionWrap--inline::before
-.ActionList-item:not(.ActionList-item--hasSubItem):hover .ActionList-item-label::before
-.ActionList-item:not(.ActionList-item--hasSubItem):hover+.ActionList-item .ActionList-item-descriptionWrap--inline::before
-.ActionList-item:not(.ActionList-item--hasSubItem):hover+.ActionList-item .ActionList-item-label::before
-.ActionList-item:not(.ActionList-item--hasSubItem):hover:not(.ActionList-item--navActive):not(:focus-visible)
-.ActionList-item[aria-checked=false] .ActionList-item-multiSelectCheckmark
-.ActionList-item[aria-checked=false] .ActionList-item-multiSelectIcon .ActionList-item-multiSelectIconRect
-.ActionList-item[aria-checked=false] .ActionList-item-multiSelectIconRect
-.ActionList-item[aria-checked=false] .ActionList-item-singleSelectCheckmark
-.ActionList-item[aria-checked=true] .ActionList-item-multiSelectCheckmark
-.ActionList-item[aria-checked=true] .ActionList-item-multiSelectIcon .ActionList-item-multiSelectCheckmark
-.ActionList-item[aria-checked=true] .ActionList-item-multiSelectIcon .ActionList-item-multiSelectIconRect
-.ActionList-item[aria-checked=true] .ActionList-item-singleSelectCheckmark
-.ActionList-item[aria-disabled=true] .ActionList-content .ActionList-item-description
-.ActionList-item[aria-disabled=true] .ActionList-content .ActionList-item-label
-.ActionList-item[aria-disabled=true] .ActionList-content .ActionList-item-visual
-.ActionList-item[aria-disabled=true]:hover
-.ActionList-item[aria-selected=false] .ActionList-item-multiSelectCheckmark
-.ActionList-item[aria-selected=false] .ActionList-item-multiSelectIcon .ActionList-item-multiSelectIconRect
-.ActionList-item[aria-selected=false] .ActionList-item-multiSelectIconRect
-.ActionList-item[aria-selected=false] .ActionList-item-singleSelectCheckmark
-.ActionList-item[aria-selected=true]
-.ActionList-item[aria-selected=true] .ActionList-item-multiSelectCheckmark
-.ActionList-item[aria-selected=true] .ActionList-item-multiSelectIcon .ActionList-item-multiSelectCheckmark
-.ActionList-item[aria-selected=true] .ActionList-item-multiSelectIcon .ActionList-item-multiSelectIconRect
-.ActionList-item[aria-selected=true] .ActionList-item-singleSelectCheckmark
-.ActionList-item[aria-selected=true]+.ActionList-item::before
-.ActionList-item[aria-selected=true]::after
-.ActionList-item[aria-selected=true]::before
-.ActionList-item[aria-selected=true]:hover
-.ActionList-item[hidden]+.ActionList-sectionDivider
-.ActionList-sectionDivider .ActionList-sectionDivider-title
-.ActionList-sectionDivider+.ActionList-item .ActionList-item-descriptionWrap--inline::before
-.ActionList-sectionDivider+.ActionList-item .ActionList-item-label::before
-.ActionList-sectionDivider--filled
-.ActionList-sectionDivider--filled:empty
-.ActionList-sectionDivider--filled:first-child
-.ActionList-sectionDivider:empty
-.ActionList-sectionDivider:not(:empty)
 .AnimatedEllipsis
@@ -291,2 +154,3 @@
 .FormControl-caption
+.FormControl-check-group-wrap fieldset
 .FormControl-checkbox-wrap
@@ -295,2 +159,3 @@
 .FormControl-checkbox-wrap .FormControl-radio-labelWrap
+.FormControl-horizontalGroup
 .FormControl-inlineValidation
@@ -341,2 +206,3 @@
 .FormControl-label
+.FormControl-radio-group-wrap fieldset
 .FormControl-radio-wrap
@@ -367,2 +233,3 @@
 .FormControl-select[readonly]
+.FormControl-spacingWrapper
 .FormControl-textarea
@@ -878,2 +745,3 @@
 .ToggleSwitch-track *
+.ToggleSwitch-track:active
 .ToggleSwitch-track:before
@@ -881,2 +749,3 @@
 .ToggleSwitch-track:focus-visible
+.ToggleSwitch-track:hover
 .ToggleSwitch-track[aria-checked=true]
@@ -885,10 +754,5 @@
 .ToggleSwitch-track[aria-checked=true] .ToggleSwitch-lineIcon
-.ToggleSwitch-track[aria-checked=true]:active
-.ToggleSwitch-track[aria-checked=true]:hover
+.ToggleSwitch-track[aria-checked=true]:not([aria-disabled=true]):active
+.ToggleSwitch-track[aria-checked=true]:not([aria-disabled=true]):hover
 .ToggleSwitch-track[aria-checked=true][aria-disabled=true]
-.ToggleSwitch-track[aria-checked=true][aria-disabled=true] .ToggleSwitch-knob
-.ToggleSwitch-track[aria-checked=true][aria-disabled=true]:active
-.ToggleSwitch-track[aria-checked=true][aria-disabled=true]:active .ToggleSwitch-knob
-.ToggleSwitch-track[aria-checked=true][aria-disabled=true]:hover
-.ToggleSwitch-track[aria-checked=true][aria-disabled=true]:hover .ToggleSwitch-knob
 .ToggleSwitch-track[aria-disabled=true]
@@ -896,10 +760,4 @@
 .ToggleSwitch-track[aria-disabled=true] .ToggleSwitch-knob
-.ToggleSwitch-track[aria-disabled=true] .ToggleSwitch-knob:active
-.ToggleSwitch-track[aria-disabled=true] .ToggleSwitch-knob:hover
 .ToggleSwitch-track[aria-disabled=true] .ToggleSwitch-lineIcon
-.ToggleSwitch-track[aria-disabled=true]:active .ToggleSwitch-knob
-.ToggleSwitch-track[aria-disabled=true]:hover .ToggleSwitch-knob
 .ToggleSwitch.ToggleSwitch
-.ToggleSwitch:active .ToggleSwitch-knob
-.ToggleSwitch:hover .ToggleSwitch-knob
 .Truncate
@@ -1155,3 +1013,2 @@
 .btn .dropdown-caret
-.btn .manual-file-chooser
 .btn .octicon
@@ -1427,4 +1284,2 @@
 .color-shadow-small
-.composer .comment-form-textarea
-.composer .tabnav
 .container-lg
@@ -1499,6 +1354,2 @@
 .details-reset>summary:focus:not(:focus-visible)
-.diffstat
-.diffstat-block-added
-.diffstat-block-deleted
-.diffstat-block-neutral
 .direction-lg-ltr
@@ -1513,11 +1364,2 @@
 .direction-xl-rtl
-.drag-and-drop
-.drag-and-drop .default
-.drag-and-drop .error
-.drag-and-drop .loading
-.drag-and-drop img
-.drag-and-drop-error-info
-.drag-and-drop-error-info a
-.dragover .drag-and-drop
-.dragover textarea
 .dropdown
@@ -1815,3 +1657,2 @@
 .focus
-.form-action-spacious
 .form-actions .btn
@@ -1986,4 +1827,2 @@
 .hover-grow:hover
-.inline-form
-.inline-form .btn-plain
 .input-block
@@ -2008,12 +1847,2 @@
 .input-sm
-.is-bad-file .drag-and-drop .bad-file
-.is-bad-permissions .drag-and-drop .bad-permissions
-.is-default .drag-and-drop .default
-.is-duplicate-filename .drag-and-drop .duplicate-filename
-.is-empty .drag-and-drop .empty
-.is-failed .drag-and-drop .failed-request
-.is-hidden-file .drag-and-drop .hidden-file
-.is-repository-required .drag-and-drop .repository-required
-.is-too-big .drag-and-drop .too-big
-.is-uploading .drag-and-drop .loading
 .label
@@ -2178,4 +2007,2 @@
 .m-xl-6
-.manual-file-chooser
-.manual-file-chooser:hover+.manual-file-chooser-text
 .markdown-body
@@ -3275,11 +3102,2 @@
 .pr-xl-9
-.previewable-comment-form
-.previewable-comment-form .comment
-.previewable-comment-form .comment-form-error
-.previewable-comment-form .preview-content
-.previewable-comment-form .tabnav
-.previewable-comment-form .write-content
-.previewable-comment-form textarea
-.previewable-comment-form.preview-selected .preview-content
-.previewable-comment-form.write-selected .write-content
 .pt-0
@@ -3653,2 +3471,3 @@
 .show-on-focus:focus
+.show-on-focus:not(:focus)
 .show-whenNarrow
@@ -3893,6 +3712,2 @@
 .top-xl-auto
-.upload-enabled textarea
-.upload-enabled.focused
-.upload-enabled.focused .drag-and-drop
-.upload-enabled.focused .form-control
 .user-select-none
@@ -3916,3 +3731,2 @@
 .width-xl-auto
-.write-content
 .ws-normal
@@ -4039,3 +3853,2 @@
 dfn
-div.composer
 fieldset
@@ -4050,3 +3863,2 @@
 h2
-h2.account
 h3
@@ -4112,6 +3924,2 @@
 p
-p.explain
-p.explain .minibutton
-p.explain .octicon
-p.explain strong
 pre

@primer-css primer-css temporarily deployed to github-pages February 28, 2023 06:10 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to Storybook Preview February 28, 2023 06:10 Inactive
@primer-css primer-css force-pushed the changeset-release/main branch 5 times, most recently from d69ccd9 to af9f023 Compare March 6, 2023 19:02
@github-actions github-actions bot temporarily deployed to Storybook Preview March 6, 2023 19:09 Inactive
@github-actions github-actions bot temporarily deployed to Storybook Preview March 6, 2023 19:09 Inactive
@primer-css primer-css temporarily deployed to github-pages March 6, 2023 19:10 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to Storybook Preview March 6, 2023 19:11 Inactive
@github-actions github-actions bot temporarily deployed to Storybook Preview March 6, 2023 19:11 Inactive
@primer-css primer-css force-pushed the changeset-release/main branch from af9f023 to f69d46b Compare March 22, 2023 14:33
@primer-css primer-css temporarily deployed to github-pages March 22, 2023 14:42 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to Storybook Preview March 22, 2023 14:43 Inactive
@primer-css primer-css force-pushed the changeset-release/main branch from f69d46b to 641fcfd Compare March 27, 2023 13:41
@primer-css primer-css temporarily deployed to github-pages March 27, 2023 13:51 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to Storybook Preview March 27, 2023 13:52 Inactive
@primer-css primer-css force-pushed the changeset-release/main branch 2 times, most recently from 36832d1 to f7d0027 Compare March 28, 2023 23:28
@github-actions github-actions bot temporarily deployed to Storybook Preview March 28, 2023 23:32 Inactive
@primer-css primer-css temporarily deployed to github-pages March 28, 2023 23:37 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to Storybook Preview March 28, 2023 23:37 Inactive
@primer-css primer-css force-pushed the changeset-release/main branch from f7d0027 to 69e078c Compare March 29, 2023 09:13
@primer-css primer-css temporarily deployed to github-pages March 29, 2023 09:20 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to Storybook Preview March 29, 2023 09:20 Inactive
simurai
simurai requested changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@simurai simurai left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't merge yet. Still waiting for #2409.

@primer-css primer-css force-pushed the changeset-release/main branch from 69e078c to 2c0bcb2 Compare March 30, 2023 01:21
@primer-css primer-css temporarily deployed to github-pages March 30, 2023 01:27 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to Storybook Preview March 30, 2023 01:27 Inactive
@primer-css primer-css force-pushed the changeset-release/main branch from 2c0bcb2 to 59a2f4d Compare March 30, 2023 12:57
@github-actions github-actions bot temporarily deployed to Storybook Preview March 30, 2023 13:04 Inactive
@simurai
Copy link
Contributor

simurai commented Mar 31, 2023

Started testing the RC in https://github.com/github/github/pull/267590.

@simurai simurai merged commit 2221a29 into main Mar 31, 2023
@simurai simurai deleted the changeset-release/main branch March 31, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simurai simurai simurai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@primer-css @simurai