Skip to content
This repository has been archived by the owner on Mar 31, 2020. It is now read-only.

Fix inability to pass args with brackets around entrypoint #3

Merged
merged 5 commits into from
Feb 5, 2019
Merged

Fix inability to pass args with brackets around entrypoint #3

merged 5 commits into from
Feb 5, 2019

Conversation

shawnbot
Copy link
Contributor

@shawnbot shawnbot commented Feb 2, 2019

Hat tip to @mcolyer for figuring this out! ❤️

@shawnbot shawnbot requested a review from emplums February 2, 2019 00:05
emplums
emplums reviewed Feb 2, 2019
View reviewed changes
Copy link
Contributor

@emplums emplums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woooooow! Nice catch 😹 my only suggestion is to update the code example with a real life runs & args value to make it easier to understand

@shawnbot
Copy link
Contributor Author

shawnbot commented Feb 4, 2019

@emplums I did update the docs; how's this look to you?

https://github.com/primer/deploy/blob/bracket-entrypoint/README.md#usage

@shawnbot shawnbot mentioned this pull request Feb 5, 2019
Merged
emplums
emplums reviewed Feb 5, 2019
View reviewed changes
shawnbot
shawnbot commented Feb 5, 2019
View reviewed changes
@shawnbot shawnbot merged commit 789f1f8 into master Feb 5, 2019
@shawnbot shawnbot deleted the bracket-entrypoint branch February 11, 2019 19:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@emplums emplums emplums left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shawnbot @emplums