Release 1.0.2 #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawnbot
reviewed
Jul 23, 2018
CHANGELOG.md
Outdated
| #### :bug: Bug Fix | ||
| * [#3](https://github.com/primer/primer-primitives/pull/6) Fix spacing so to be an array instead of an object. ([@broccolini](https://github.com/broccolini)) | ||
|
|
||
| #### :house: Internal |
There was a problem hiding this comment.
This should probably be 📝 Documentation, no?
shawnbot
reviewed
Jul 23, 2018
CHANGELOG.md
Outdated
| # 1.0.2 (2018-07-20) | ||
|
|
||
| #### :bug: Bug Fix | ||
| * [#3](https://github.com/primer/primer-primitives/pull/6) Fix spacing so to be an array instead of an object. ([@broccolini](https://github.com/broccolini)) |
shawnbot
approved these changes
Jul 23, 2018
emplums
reviewed
Jul 23, 2018
|
|
||
| const App = props => ( | ||
| <ThemeProvider theme={theme}> | ||
| <Alert color='green.0' bg='green.2' /> |
There was a problem hiding this comment.
Does styled-system do the magic of converting the string green.0 to theme.colors.green[0]? Or is there any extra set-up you need to do to get that to work besides passing the theme file into ThemeProvider?
There was a problem hiding this comment.
The answer is essentially yes, no extra step. Here is the code if you are curious about the implementation https://github.com/jxnblk/styled-system/blob/master/src/util.js#L22-L23
There was a problem hiding this comment.
Hah, I found a bug in that code @broccolini: styled-system/styled-system#254 🤓
emplums
approved these changes
Jul 23, 2018
This was referenced Dec 13, 2022
This was referenced Dec 20, 2022
This was referenced Dec 23, 2022
This was referenced Dec 31, 2022
This was referenced Jan 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5 and #4
In this pr:
To do