Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(BaseStyles): set data-color-mode to auto when auto color mode #5649

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

joshblack
Copy link
Member

Update our BaseStyles component to set data-color-mode to auto when the colorMode is set to auto. This helps us out on the primer-docs side when we are doing SSR so that the fallbacks of custom properties resolve to the correct theme.

Changelog

New

Changed

  • Update our BaseStyles component to set data-color-mode to auto when the colorMode is set to auto

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

@joshblack joshblack requested a review from a team as a code owner February 3, 2025 19:00
@joshblack joshblack requested a review from jonrohan February 3, 2025 19:00
Copy link

changeset-bot bot commented Feb 3, 2025

🦋 Changeset detected

Latest commit: 3a6859e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Feb 3, 2025
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Feb 3, 2025
Copy link
Contributor

github-actions bot commented Feb 3, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

Copy link
Contributor

github-actions bot commented Feb 3, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 105.64 KB (+0.07% 🔺)
packages/react/dist/browser.umd.js 106.11 KB (+0.07% 🔺)

@github-actions github-actions bot temporarily deployed to storybook-preview-5649 February 3, 2025 19:16 Inactive
@joshblack joshblack added this pull request to the merge queue Feb 4, 2025
@joshblack joshblack removed this pull request from the merge queue due to a manual request Feb 4, 2025
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/360763

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Feb 4, 2025
@primer-integration
Copy link

🟢 golden-jobs completed with status success.

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Feb 13, 2025
Copy link
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants