Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preliminary description of how we integrate with cookies #145

Merged
merged 5 commits into from
Jan 5, 2023

Conversation

johannhof
Copy link
Member

@johannhof johannhof commented Dec 14, 2022

This is a bit hand-wavy but approximately what we discussed should live in this section at TPAC.


Preview | Diff

@johannhof
Copy link
Member Author

(closes #31)

Copy link
Collaborator

@bvandersloot-mozilla bvandersloot-mozilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but this is out of my comfort zone specs.

@johannhof
Copy link
Member Author

Thanks, Ben! @annevk did you want to take another look? I try to mention SameSite here, but also realized it's not even standardized yet, so I'm not sure what to make of that.

Copy link
Collaborator

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing this! I know this is a thing some of your colleagues have been interested in reading for quite a while now. 😊

Approved modulo nits.

johannhof and others added 3 commits January 5, 2023 13:07
Co-authored-by: Anne van Kesteren <[email protected]>
Co-authored-by: Anne van Kesteren <[email protected]>
Co-authored-by: Anne van Kesteren <[email protected]>
@johannhof johannhof merged commit 54caceb into privacycg:main Jan 5, 2023
@johannhof johannhof deleted the cookies branch January 5, 2023 12:09
@privacycg privacycg deleted a comment from luiselullgar23 Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants