Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Updated Bitwarden logo #1968

Merged
merged 3 commits into from
Jul 2, 2020
Merged

Conversation

jackmchou
Copy link
Contributor

@jackmchou jackmchou commented Jun 30, 2020

Description

Resolves: #1960

Check List

  • I understand that by not opening an issue about a software/service/similar addition/removal, this pull request will be closed without merging.

  • I have read and understand the contributing guidelines.

  • The project is Free Libre and/or Open Source Software

@jackmchou jackmchou requested a review from a team as a code owner June 30, 2020 14:43
@jackmchou jackmchou changed the title Updated Bitwarden logo Issue #1960 Updated Bitwarden logo Jun 30, 2020
@dngray
Copy link
Collaborator

dngray commented Jul 2, 2020

We like to optimize all SVGs we add to the site. This is a helpful guide as to how we do it with Inkscape:

optimize_svg

@jackmchou
Copy link
Contributor Author

We like to optimize all SVGs we add to the site. This is a helpful guide as to how we do it with Inkscape:

optimize_svg

Got it! Will do in the future. Could I also update the contributing guidelines with this information?

@nitrohorse
Copy link
Contributor

@jackmchou that’s a good idea! Having the optimization recommendation somewhere visible will be helpful.

@nitrohorse nitrohorse merged commit 801e7a1 into privacytools:master Jul 2, 2020
@jackmchou jackmchou deleted the issue-1960 branch July 2, 2020 18:08
@dngray
Copy link
Collaborator

dngray commented Jul 3, 2020

Got it! Will do in the future. Could I also update the contributing guidelines with this information?

We should do that actually, and also mention that images must be 128x128 or 384x128. It is also a good idea to copy the SVG content to a new SVG document and adjust canvas size. That fixes some breakages with rendering.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📝 Correction | Bitwarden Logo
3 participants