Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add aria attributes to menus #2968

Closed
wants to merge 1 commit into from

Conversation

lindapaiste
Copy link
Collaborator

@lindapaiste lindapaiste commented Jan 27, 2024

Ref #2933 (comment)

Changes:

  • Add role="menu" and role="menuitem" to dropdown menus
  • Add role="menubar" and role="menuitem" to header nav bar
  • Add aria-haspopup="menu" to dropdown anchors

Pending:

  • Validate that the markup is correct
  • Investigate using role="group" for the left and right portions of the nav bar
  • Add role="menuitem" to nav bar items which do not have dropdowns (login and sign up)
  • Figure out the proper way to keep the "navigation" role on the nav while also having a "menubar" role
  • Use aria-expanded to indicate if the dropdown is open or closed

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@lindapaiste lindapaiste added the Area:Accessibility Category for accessibility related features and bugs label Jan 27, 2024
@Prateek-Fst
Copy link

<img width="1440" alt="Screenshot 2024-02-01 at 5 23 05 PM" src="https://github.com/processing/p5.js-web-editor/assets/14790699
Screenshot 2024-02-01 at 5 23 37 PM
9/f
Screenshot 2024-02-01 at 5 23 21 PM
8951812-1110-4cbe-b618-74684c3be8c5">
these are the few changes I have made in the code base of Nav.jsx, What are your thoughts on this ..? @lindapaiste , Should I commit these changes

@tespin
Copy link
Contributor

tespin commented Jul 1, 2024

commenting here to see if @Prateek-Fst or anyone else is still working on this -- I'm learning more about aria markup and would love to pick up the issue from here if possible. @lindapaiste 🙂

edit: going to give it a go!

@raclim
Copy link
Collaborator

raclim commented Jul 19, 2024

Closing as addressed by #3191

@raclim raclim closed this Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area:Accessibility Category for accessibility related features and bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants