[WIP] Add aria attributes to menus #2968
Closed
+11
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #2933 (comment)
Changes:
role="menu"
androle="menuitem"
to dropdown menusrole="menubar"
androle="menuitem"
to header nav bararia-haspopup="menu"
to dropdown anchorsPending:
role="group"
for the left and right portions of the nav barrole="menuitem"
to nav bar items which do not have dropdowns (login and sign up)"navigation"
role on the nav while also having a"menubar"
rolearia-expanded
to indicate if the dropdown is open or closedI have verified that this pull request:
npm run lint
)npm run test
)develop
branch.Fixes #123