Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of Rails specific method Hash::except #140

Merged
merged 1 commit into from
Mar 14, 2019
Merged

Remove usage of Rails specific method Hash::except #140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
## 0.13.2 - 2019/03/14
* 🐛 [BUGFIX] Replacing use of rails-specific method `Hash::except` so that Blueprinter continues to work in non-Rails environments. [#140](https://github.com/procore/blueprinter/pull/140). Thanks to [@checkbutton](https://github.com/checkbutton).

## 0.13.1 - 2019/03/02
* 💅 [MAINTENANCE | ENHANCEMENT] Cleaning up the `include_associations` section. This is not a documented/supported feature and is calling `respond_to?(:klass)` on every object passed to blueprinter. [#139](https://github.com/procore/blueprinter/pull/139). Thanks to [@ritikesh](https://github.com/ritikesh).

Expand Down
3 changes: 2 additions & 1 deletion lib/blueprinter/extractors/association_extractor.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@ def initialize
end

def extract(association_name, object, local_options, options={})
value = @extractor.extract(association_name, object, local_options, options.except(:default))
options_without_default = options.reject { |k,_| k == :default }
value = @extractor.extract(association_name, object, local_options, options_without_default)
return default_value(options) if value.nil?
view = options[:view] || :default
blueprint = association_blueprint(options[:blueprint], value)
Expand Down
2 changes: 1 addition & 1 deletion lib/blueprinter/version.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module Blueprinter
VERSION = '0.13.1'
VERSION = '0.13.2'
end