-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return MFX_ERR_INCOMPATIBLE_VIDEO_PARAM once parameter is changed #41
base: main
Are you sure you want to change the base?
Conversation
Improper Commit Message |
c7ac087
to
7bc0bcd
Compare
Improper Commit Message |
7bc0bcd
to
5c819a8
Compare
Improper Commit Message |
5c819a8
to
042d521
Compare
@nanazhan @TianmiChen @lsun30 Please help review the patches |
@@ -1050,7 +1050,8 @@ mfxStatus VideoDECODEH265::DecodeFrameCheck(mfxBitstream *bs, mfxFrameSurface1 * | |||
{ | |||
if (!m_isFirstRun) | |||
{ | |||
sts = MFX_WRN_VIDEO_PARAM_CHANGED; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not suggesting change this logic in VPL. MFX_WRN_VIDEO_PARAM_CHANGED means the decoder detected a new sequence header. Some parameters may be changed in the new sequence. For some parameters changed, decoder can still work fine without re-init decoder. Please try to call MFXVideoDECODE_GetVideoParam(session, &newParams) to get the new parameters after MFXVideoDECODE_DecodeFrameAsync returned MFX_WRN_VIDEO_PARAM_CHANGED in Codec2.0, if color aspects really differ, then close the decoder and re-init decoder.
For AVC and HEVC decoder, once parameter including colorAspect and bitDepth is changed, MFX_ERR_INCOMPATIBLE_VIDEO_PARAM is returned. In order to inform c2-plugin to re-init decoder for parameter changes Tracked-On: OAM-130444 Signed-off-by: Shao-Feng <[email protected]>
Return MFX_ERR_INCOMPATIBLE_VIDEO_PARAM once parameter is changed
For AVC and HEVC decoder, once parameter including colorAspect and
bitDepth is changed, MFX_ERR_INCOMPATIBLE_VIDEO_PARAM is returned.
In order to inform c2-plugin to re-init decoder for parameter changes