Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return MFX_ERR_INCOMPATIBLE_VIDEO_PARAM once parameter is changed #41

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Shao-Feng
Copy link
Contributor

@Shao-Feng Shao-Feng commented Feb 13, 2025

Return MFX_ERR_INCOMPATIBLE_VIDEO_PARAM once parameter is changed
For AVC and HEVC decoder, once parameter including colorAspect and
bitDepth is changed, MFX_ERR_INCOMPATIBLE_VIDEO_PARAM is returned.
In order to inform c2-plugin to re-init decoder for parameter changes

@sysopenci
Copy link

Improper Commit Message
Tracked on not found in commit message,
make sure Tracked-On: Jira-ticket is present.

@sysopenci
Copy link

Improper Commit Message
Jira issue not in ['bug','improvement'],
make sure jira issue is of type bug or improvement.

@Shao-Feng Shao-Feng changed the title Commit feb 13 Return MFX_ERR_INCOMPATIBLE_VIDEO_PARAM once parameter is changed Feb 21, 2025
@sysopenci
Copy link

Improper Commit Message
Jira issue not in ['bug','improvement'],
make sure jira issue is of type bug or improvement.

@feijiang1
Copy link

@nanazhan @TianmiChen @lsun30 Please help review the patches

@@ -1050,7 +1050,8 @@ mfxStatus VideoDECODEH265::DecodeFrameCheck(mfxBitstream *bs, mfxFrameSurface1 *
{
if (!m_isFirstRun)
{
sts = MFX_WRN_VIDEO_PARAM_CHANGED;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not suggesting change this logic in VPL. MFX_WRN_VIDEO_PARAM_CHANGED means the decoder detected a new sequence header. Some parameters may be changed in the new sequence. For some parameters changed, decoder can still work fine without re-init decoder. Please try to call MFXVideoDECODE_GetVideoParam(session, &newParams) to get the new parameters after MFXVideoDECODE_DecodeFrameAsync returned MFX_WRN_VIDEO_PARAM_CHANGED in Codec2.0, if color aspects really differ, then close the decoder and re-init decoder.

For AVC and HEVC decoder, once parameter including colorAspect and
bitDepth is changed, MFX_ERR_INCOMPATIBLE_VIDEO_PARAM is returned.
In order to inform c2-plugin to re-init decoder for parameter changes

Tracked-On: OAM-130444
Signed-off-by: Shao-Feng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Build Not Started Engineering Build Not Started Pending Developer Approval Pending Developer Approval Pending PR Review Pending PR Review Valid commit message
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants