Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gateway API: implement HTTP query param matching [extended] #4089

Closed
skriss opened this issue Oct 8, 2021 · 3 comments · Fixed by #4588
Closed

Gateway API: implement HTTP query param matching [extended] #4089

skriss opened this issue Oct 8, 2021 · 3 comments · Fixed by #4588
Assignees
@skriss
Labels
area/gateway-api Issues or PRs related to the Gateway (Gateway API working group) API. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@skriss
Copy link
Member

skriss commented Oct 8, 2021

ref. https://gateway-api.sigs.k8s.io/v1alpha2/references/spec/#gateway.networking.k8s.io/v1alpha2.HTTPQueryParamMatch

extended support in v1alpha2.
@skriss skriss added kind/feature Categorizes issue or PR as related to a new feature. area/gateway-api Issues or PRs related to the Gateway (Gateway API working group) API. lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. labels Oct 8, 2021
@skriss skriss assigned skriss and abhide and unassigned skriss Dec 7, 2021
@skriss skriss added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jan 6, 2022
@skriss skriss added this to the 1.21.0 milestone Jan 31, 2022
@sunjayBhatia
Copy link
Member

@abhide are you working on this one? 1.21 is coming soon so just wanted to check in

@skriss skriss changed the title Gateway API: implement HTTP query param matching Gateway API: implement HTTP query param matching [extended] Apr 27, 2022
@skriss skriss modified the milestones: 1.21.0, 1.22.0 Apr 27, 2022
@skriss
Copy link
Member Author

skriss commented May 17, 2022

Removing from the 1.22 milestone, still open to a contributor picking this up though!

@skriss skriss removed this from the 1.22.0 milestone May 19, 2022
@skriss skriss assigned skriss and unassigned abhide Jun 17, 2022
@skriss
Copy link
Member Author

skriss commented Jun 17, 2022

I'll work on this in the background and see if we can get it in for 1.22, main challenge is figuring out how to sort various routes that have combos of prefix, header and query param matches.

@skriss skriss removed help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. labels Jun 21, 2022
skriss added a commit to skriss/contour that referenced this issue Jun 21, 2022
@skriss
Gateway API: implement HTTP query param matching
8ee1bf7 
Closes projectcontour#4089.

Signed-off-by: Steve Kriss <[email protected]>
skriss added a commit to skriss/contour that referenced this issue Jun 21, 2022
@skriss
Gateway API: implement HTTP query param matching
17e1388 
Closes projectcontour#4089.

Signed-off-by: Steve Kriss <[email protected]>
skriss added a commit to skriss/contour that referenced this issue Jun 22, 2022
@skriss
Gateway API: implement HTTP query param matching
1328e49 
Closes projectcontour#4089.

Signed-off-by: Steve Kriss <[email protected]>
@skriss skriss mentioned this issue Jun 22, 2022
Merged
skriss added a commit to skriss/contour that referenced this issue Jun 22, 2022
@skriss
Gateway API: implement HTTP query param matching
04667bf 
Closes projectcontour#4089.

Signed-off-by: Steve Kriss <[email protected]>
skriss added a commit that referenced this issue Jun 23, 2022
@skriss
Gateway API: implement HTTP query param matching (#4588)
817f857 
Closes #4089.

Signed-off-by: Steve Kriss <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skriss skriss

Labels
area/gateway-api Issues or PRs related to the Gateway (Gateway API working group) API. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Gateway API: implement HTTP query param matching skriss/contour
3 participants
@abhide @skriss @sunjayBhatia