Add missing ttl in pushhover (#3474)

--------- Signed-off-by: Hélia Barroso <[email protected]> Signed-off-by: Simon Pasquier <[email protected]> Co-authored-by: Simon Pasquier <[email protected]>
prometheus · Aug 31, 2023 · ba30364 · ba30364
1 parent 6cbe2eb
commit ba30364
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 0 deletions.
diff --git a/config/notifiers.go b/config/notifiers.go
@@ -694,6 +694,7 @@ type PushoverConfig struct {
 	Priority    string   `yaml:"priority,omitempty" json:"priority,omitempty"`
 	Retry       duration `yaml:"retry,omitempty" json:"retry,omitempty"`
 	Expire      duration `yaml:"expire,omitempty" json:"expire,omitempty"`
+	TTL         duration `yaml:"ttl,omitempty" json:"ttl,omitempty"`
 	HTML        bool     `yaml:"html" json:"html,omitempty"`
 }
 

diff --git a/docs/configuration.md b/docs/configuration.md
@@ -948,6 +948,9 @@ token_file: <filepath>
 # acknowledges the notification.
 [ expire: <duration> | default = 1h ]
 
+# Optional time to live (TTL) to use for notification, see https://pushover.net/api#ttl
+[ ttl: <duration> ]
+
 # The HTTP client's configuration.
 [ http_config: <http_config> | default = global.http_config ]
 ```

diff --git a/notify/pushover/pushover.go b/notify/pushover/pushover.go
@@ -147,6 +147,12 @@ func (n *Notifier) Notify(ctx context.Context, as ...*types.Alert) (bool, error)
 	parameters.Add("expire", fmt.Sprintf("%d", int64(time.Duration(n.conf.Expire).Seconds())))
 	parameters.Add("device", tmpl(n.conf.Device))
 	parameters.Add("sound", tmpl(n.conf.Sound))
+
+	newttl := int64(time.Duration(n.conf.TTL).Seconds())
+	if newttl > 0 {
+		parameters.Add("ttl", fmt.Sprintf("%d", newttl))
+	}
+
 	if err != nil {
 		return false, err
 	}