Display Silence and Alert dates in ISO8601 format #2363
Conversation
nicholascapo
commented
Sep 2, 2020
nicholascapo
commented
- This changes the Alert view the SilenceList and SilenceView
nicholascapo
force-pushed
the
displays_use_iso_datetime_format
branch
2 times, most recently
from
18ee0b4 to
b453648
Compare
nicholascapo
force-pushed
the
displays_use_iso_datetime_format
branch
from
b453648 to
56a7bc1
Compare
|
I don't have strong preferences on date formatting for the UI but I'm not sure that switching to ISO8601 format is more useful than the current format. |
|
My use case is actually comparing the dates in AM to the dates a lot of other tools (Grafana, PagerDuty, etc) that use the ISO format. If they all had the same structure, doing quick diffs in my head would be easier (e.g "How long before this page did the Silence expire?") The change would also make these dates consistent with the format on the New Silence Page. Personally I like the ISO format, but internal and external consistency is the goal here. |
|
Thanks for the input Nicholas. I agree that reducing cognitive overhead is important. I'll let @roidelapluie and @w0rm chime in too... |
|
We should keep that consistent with Prometheus. |
|
See also: prometheus/prometheus#7884 |
I agree that we should keep it consistent! 👍 if we are going change this in Prometheus too. |
nicholascapo
force-pushed
the
displays_use_iso_datetime_format
branch
from
56a7bc1 to
2d6711a
Compare
* This changes the Alert view the SilenceList and SilenceView Signed-off-by: Nicholas Capo <[email protected]>
nicholascapo
force-pushed
the
displays_use_iso_datetime_format
branch
from
2d6711a to
51cf51a
Compare
|
Any word on this change? Can I get an approval? |
|
@nicholascapo sure, to make it more consistent with Prometheus 👍 |
