Emit warning-level logs when truncating messages in notifications #3145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexweav
commented
Nov 25, 2022
notify/opsgenie/opsgenie.go
Outdated
| if truncated { | ||
| level.Debug(n.logger).Log("msg", "truncated message", "truncated_message", message, "alert", key) | ||
| level.Debug(n.logger).Log("msg", "Truncated message", "alert", key, "runes", maxMessageLenRunes) |
There was a problem hiding this comment.
Standardized the capitalization of these to use a capital at the beginning. Please let me know if you'd rather me go the other way.
simonpasquier
approved these changes
Dec 7, 2022
|
hey @gotjosh, any final comments here? |
gotjosh
approved these changes
Dec 13, 2022
Signed-off-by: Alex Weaver <[email protected]>
Signed-off-by: Alex Weaver <[email protected]>
Signed-off-by: Alex Weaver <[email protected]>
Signed-off-by: Alex Weaver <[email protected]>
Signed-off-by: Alex Weaver <[email protected]>
Signed-off-by: Alex Weaver <[email protected]>
Signed-off-by: Alex Weaver <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some integrations define maximum lengths of messages that they accept. We usually respect these, by truncating the user's message for them.
Since we are actively modifying what the user asked us to send, let's log this event at warning level. That way, operators can more easily see when their message is too long, and know that we changed it for them.
Fixes #3134
We no longer log the full-blown message per #3134 (comment).