-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adaptive Cards Support #3799
base: main
Are you sure you want to change the base?
Adaptive Cards Support #3799
Conversation
b3edaa8
to
0c6c4ac
Compare
Thanks for making this MR @6fears7 ! Happy to assist on this. |
Signed-off-by: Preston <[email protected]>
Signed-off-by: Preston <[email protected]>
Signed-off-by: Preston <[email protected]>
661038e
to
1e078ec
Compare
@aw1cks, Thank you for the initial contribution / idea. I actually would love your assistance on this as I'm strapped for free time currently. If you can address the CI test failures / implement the test cases, that would be awesome. Until a maintainer says otherwise, perhaps it would be best to just write this as a hard cut to AdaptiveCards versus offering support for both. The original template file for msteams seemed to be using internal markdown to submit the alert data and is the cause for the test failure since it's expecting JSON format. Feel free to ping me as needed. |
Thanks for opening a PR for this! I think support for Adaptive Cards would be great feature to have in Alertmanager. However, I do think there are a couple of problems with this specific implementation:
My suggestion would be to try and come up with an abstraction for Adaptive Cards in YAML. An example of this is the draft PR I opened for Slack Block Kit (see #3381). I am interested to see what you can come up with for Microsoft Teams. |
@grobinson-grafana i've tried to think about an abstraction in yaml for adaptative cards but that would then end put putting a rigid adaptive card structure in the receiver, so not sure it's also the best way to handle this correctly. |
Yes, it is hard! I hope we can solve it rather than push the problem onto users (i.e. templating JSON with Go templates in YAML 😢).
I don't understand what you mean here though? |
UPDATE ignore my comment , i'm dump that's all , should have read more carefully :( |
To continue #3503.
Credit to @aw1cks provided the original code, I slightly tweaked it.
Notables from that feature request:
Firing
Template 1 (Fancy)
Template 2 (Key/ Value)
Resolved
Template 1 (Fancy)
Template 2 (Key/ Value)
Template 1 (Fancy)
Label / Annotations View:
Silences:
Template 1 (Fancy)
Uses .CommonLabels
Click to view key/value Template
Click to view fancy Template
Is there an appetite for this?