Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: cut v0.7.0-rc.0 #807

Merged
merged 1 commit into from
May 19, 2017
Merged

*: cut v0.7.0-rc.0 #807

merged 1 commit into from
May 19, 2017

Conversation

mxinden
Copy link
Member

@mxinden mxinden commented May 19, 2017

No description provided.

CHANGELOG.md Outdated
@@ -1,3 +1,13 @@
## v0.7.0-rc.0 / 2017-05-19

* [BUGFIX] Enable builds for Solaris/Illumos
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually sort things the other way around: CHANGE, FEATURE, ENHANCEMENT, BUGFIX. See prometheus/prometheus for examples.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, sorry. Changed.

CHANGELOG.md Outdated
## v0.7.0-rc.0 / 2017-05-19

* [BUGFIX] Enable builds for Solaris/Illumos
* [ENHANCEMENT] Rewrite UI from scratch improving UX
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd label this as [CHANGE] as it's so big.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, changed as well. Thanks for the feedback!

Copy link
Contributor

@stuartnelson3 stuartnelson3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✂️

@brancz
Copy link
Member

brancz commented May 19, 2017

lgtm 🚢 ✨

@mxinden mxinden merged commit 15979ce into prometheus:master May 19, 2017
hh pushed a commit to ii/alertmanager that referenced this pull request Feb 6, 2018
Export systemd timers last trigger seconds.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants