-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update supported Go versions #1602
Conversation
925733c
to
03cb470
Compare
Hmmm, strange that we got failing tests with 1.23 🤔 We also want to generate the tests for new metrics for gocollector with 1.23. We have generation scripts[1][2] for that but the result[3] is showing that we've changed the generated files manually and CI didn't block it 😬. I'm not sure how to proceed here, but it seems like we need to work on this[4] before updating the go version? |
d0f97e2
to
cb25d7a
Compare
I've re-generate and manually fixed up the tests. I'd rather not block keeping things up-to-date on automation technical debt. I need this for #1601. When the review here is complete, I will update the required tests, as this is manually done in the GitHub UI. |
cb25d7a
to
92f8c27
Compare
Now that 1.23 is out, update the supported version matrix to Go 1.21 through 1.23. This allows us to start using `log/slog`. * Update generated tests. Signed-off-by: SuperQ <[email protected]>
92f8c27
to
c85ae6b
Compare
Fair point. We can work on the automation later |
Now that 1.23 is out, update the supported version matrix to Go 1.21 through 1.23. This allows us to start using
log/slog
.