Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make prep-release.sh copy summary.md into unreleased for release candidates. #2178

Closed
wants to merge 5 commits into from

Conversation

SpicyLemon
Copy link
Contributor

@SpicyLemon SpicyLemon commented Oct 14, 2024

Description

This PR:

  • Fixes the prep-release.sh script to fix an invalid sed statement causing minor version validation to fail.
  • Makes the prep-release.sh script copy the summary.md into unreleased when the new version is a release candidate.
  • In go.mod changes the version on the import line for cosmos-sdk. There's no change to the replace line for it though, so it's not actually a version bump; it's just making that import line match the version of the SDK that our fork's replacement is based on.

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Added relevant changelog entries under .changelog/unreleased (see Adding Changes).
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

Summary by CodeRabbit

  • New Features

    • Enhanced script for handling release candidates, ensuring summary preservation.
    • Improved verbose output for better user feedback during operations.
  • Bug Fixes

    • Refined validation logic for version numbers to ensure accuracy.
  • Chores

    • Updated dependency versions for improved stability and performance.

@SpicyLemon SpicyLemon requested a review from a team as a code owner October 14, 2024 19:56
Copy link
Contributor

coderabbitai bot commented Oct 14, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces enhancements to the prep-release.sh script, focusing on handling release candidates and managing changelog entries. Key modifications include improved logic for release candidates, refined validation for version numbers, enhanced verbose output, consistent temporary directory management, and better error handling. Additionally, the go.mod file is updated to reflect a minor version upgrade of the github.com/cosmos/cosmos-sdk dependency and adjustments to replace directives for provenance-specific implementations.

Changes

File Change Summary
.changelog/prep-release.sh - Added logic for handling release candidates.
- Refined validation logic for version numbers.
- Enhanced verbose output.
- Improved temporary directory management.
- Enhanced error handling.
go.mod - Updated github.com/cosmos/cosmos-sdk from v0.50.7 to v0.50.10.
- Updated replace directives for cosmos-sdk and wasmd to provenance-specific versions.

Possibly related PRs

Suggested reviewers

  • Taztingo
  • iramiller
  • nullpointer0x00

Poem

In the burrow, scripts do play,
Enhancements made, hip-hip-hooray!
Release candidates now in sight,
With clearer paths, all feels right.
Dependencies updated, hopping along,
Changelog entries sing a new song! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@SpicyLemon SpicyLemon changed the title Dwedul/prep v1.20.0 rc1 Make prep-release.sh copy summary.md into unreleased for release candidates. Oct 14, 2024
@SpicyLemon
Copy link
Contributor Author

Gonna skip this PR and just create the release branch with the changes, then carry this back to main in the PR that marks v1.20.0-rc1 in the changelog.

@SpicyLemon SpicyLemon closed this Oct 14, 2024
@SpicyLemon SpicyLemon deleted the dwedul/prep-v1.20.0-rc1 branch October 14, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant