Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Cosmos SDK to v0.50.12-pio-1 (from v0.50.11-pio-1). #2282

Merged
merged 4 commits into from
Feb 20, 2025

Conversation

SpicyLemon
Copy link
Contributor

@SpicyLemon SpicyLemon commented Feb 20, 2025

Description

This PR will bump the SDK to v0.50.12-pio-1 (from v0.50.11-pio-1).


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Added relevant changelog entries under .changelog/unreleased (see Adding Changes).
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

Summary by CodeRabbit

  • Chores
    • Upgraded several core dependencies to the latest revisions, enhancing overall stability and performance.
    • Adjusted the linting workflow configuration to streamline code verification processes.

These maintenance updates contribute to a more robust and efficient platform experience, supporting continuous improvements behind the scenes.

@SpicyLemon SpicyLemon requested a review from a team as a code owner February 20, 2025 21:49
@SpicyLemon SpicyLemon changed the title Dwedul/bump sdk to 50.12 Bump Cosmos SDK to v0.50.12-pio-1 (from v0.50.11-pio-1). Feb 20, 2025
iramiller
iramiller previously approved these changes Feb 20, 2025
…t action recently enabled that verification by default, which is why the most recent PRs are failing the lint action.
Copy link
Contributor

coderabbitai bot commented Feb 20, 2025

Walkthrough

This pull request updates several dependency versions and makes a minor adjustment to the GitHub Actions lint job configuration. Specifically, it bumps the versions of github.com/cosmos/cosmos-db, github.com/cosmos/cosmos-sdk, and github.com/cosmos/ledger-cosmos-go. Additionally, it adds the verify: false option to the golangci-lint step in the GitHub Actions workflow. These changes are documented across the changelog and go.mod files.

Changes

Files Change Summary
.changelog/unreleased/dependencies/2282-bump-sdk-to-0-50-12.md
go.mod
Updated dependency versions for:
- github.com/cosmos/cosmos-db: v1.1.0 → v1.1.1
- github.com/cosmos/cosmos-sdk: v0.50.11-pio-1 → v0.50.12-pio-1
- github.com/cosmos/ledger-cosmos-go: v0.13.3 → v0.14.0
.github/workflows/lint.yml Added verify: false to the golangci/golangci-lint-action@v6 configuration to disable the verification process in the linting workflow.

Possibly related PRs

Suggested labels

dependencies, go

Suggested reviewers

  • iramiller

Poem

I’m a bunny in the code, hopping without a care,
Updating dependencies with a light and breezy air.
Version bumps like carrots—fresh and oh so bright,
Linting paths now smoother, coding day to night.
With each little change, my hops grow full of glee,
A joyful dance in Go-land, joyful as can be!
Happy upgrades, nibble on, in our code’s field of delight!


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@SpicyLemon SpicyLemon enabled auto-merge (squash) February 20, 2025 22:09
@SpicyLemon SpicyLemon disabled auto-merge February 20, 2025 22:09
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7e23f30 and 09d4108.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (3)
  • .changelog/unreleased/dependencies/2282-bump-sdk-to-0-50-12.md (1 hunks)
  • .github/workflows/lint.yml (1 hunks)
  • go.mod (3 hunks)
✅ Files skipped from review due to trivial changes (1)
  • .changelog/unreleased/dependencies/2282-bump-sdk-to-0-50-12.md
🧰 Additional context used
🪛 actionlint (1.7.4)
.github/workflows/lint.yml

41-41: input "verify" is not defined in action "golangci/golangci-lint-action@v6". available inputs are "args", "cache-invalidation-interval", "github-token", "install-mode", "only-new-issues", "problem-matchers", "skip-cache", "skip-save-cache", "version", "working-directory"

(action)

⏰ Context from checks skipped due to timeout of 90000ms (10)
  • GitHub Check: runsim (after-import, goleveldb, ubuntu-latest)
  • GitHub Check: go-test-multi-db (benchmark, goleveldb, ubuntu-latest)
  • GitHub Check: go-test-single-db (nondeterminism, ubuntu-latest)
  • GitHub Check: runsim (multi-seed-short, goleveldb, ubuntu-latest)
  • GitHub Check: runsim (import-export, goleveldb, ubuntu-latest)
  • GitHub Check: test-race (04)
  • GitHub Check: test-race (03)
  • GitHub Check: tests (01)
  • GitHub Check: test-race (01)
  • GitHub Check: test-race (00)
🔇 Additional comments (3)
go.mod (3)

23-23: Cosmos DB Version Bump

The Cosmos DB dependency is updated to v1.1.1 as intended. This version bump aligns with the upgrade requirements. Please ensure that integration tests covering database-related functionality are run to catch any incompatibilities.


85-85: Ledger Cosmos Go Version Update

The dependency for github.com/cosmos/ledger-cosmos-go has been updated to v0.14.0. Confirm that this update does not introduce breaking changes in ledger-related functionality by running any relevant integration or end-to-end tests.


222-222: Cosmos SDK Replacement Update

The replacement for the Cosmos SDK has been updated to github.com/provenance-io/cosmos-sdk v0.50.12-pio-1, which matches the PR objective. Please verify through your integration and unit tests that the new SDK version is fully compatible with the codebase, especially given potential upstream changes.

@SpicyLemon SpicyLemon merged commit 706e128 into main Feb 20, 2025
35 checks passed
@SpicyLemon SpicyLemon deleted the dwedul/bump-sdk-to-50.12 branch February 20, 2025 22:53
SpicyLemon added a commit that referenced this pull request Feb 20, 2025
* Switch the SDK to a local version.

* Switch to v0.50.12-pio-1

* Add changelog entry.

* Tell the lint action to not verify the json stuff. The authors of that action recently enabled that verification by default, which is why the most recent PRs are failing the lint action.
SpicyLemon added a commit that referenced this pull request Feb 21, 2025
…2283)

* Bump github.com/cometbft/cometbft from 0.38.15 to 0.38.17 (#2271)

* Bump github.com/cometbft/cometbft from 0.38.15 to 0.38.17

Bumps [github.com/cometbft/cometbft](https://github.com/cometbft/cometbft) from 0.38.15 to 0.38.17.
- [Release notes](https://github.com/cometbft/cometbft/releases)
- [Changelog](https://github.com/cometbft/cometbft/blob/v0.38.17/CHANGELOG.md)
- [Commits](cometbft/cometbft@v0.38.15...v0.38.17)

---
updated-dependencies:
- dependency-name: github.com/cometbft/cometbft
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

* Updated Changelog

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Daniel Wedul <[email protected]>

* Bump Cosmos SDK to v0.50.12-pio-1 (from v0.50.11-pio-1). (#2282)

* Switch the SDK to a local version.

* Switch to v0.50.12-pio-1

* Add changelog entry.

* Tell the lint action to not verify the json stuff. The authors of that action recently enabled that verification by default, which is why the most recent PRs are failing the lint action.

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@coderabbitai coderabbitai bot mentioned this pull request Feb 21, 2025
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants