Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ITEM_SCORED and ITEM_LEVEL in csv #848

Closed
CenturionGamer opened this issue Aug 17, 2021 · 19 comments
Closed

ITEM_SCORED and ITEM_LEVEL in csv #848

CenturionGamer opened this issue Aug 17, 2021 · 19 comments

Comments

@CenturionGamer
Copy link
Contributor

ITEM_SCORED and ITEM_LEVEL are both blank in the results. This happened for multiple checks.

@w0rmr1d3r
Copy link
Contributor

Hello @CenturionGamer !
Can you give us some images where that is failing?
How did you run Prowler?

Thanks!

@estemendoza
Copy link

Hi! I am having the same issue. I executed prowler like this: ./prowler -c check310 -M csv and then the CSV file looked like this:

Screenshot 2021-08-18 at 11 15 53

@estemendoza
Copy link

I am no good with Bash, but could this be the issue? These lines are commented out

https://github.com/toniblyx/prowler/blob/e0f60114f4465205cf782aea108c521d84a7f78d/include/outputs#L240-L258

@CenturionGamer
Copy link
Contributor Author

@w0rmr1d3r - Good morning! Thanks for responding to this issue. See the comment above from @estemendoza and the code he posted. I ran Prowler the same way as @estemendoza did.

@w0rmr1d3r
Copy link
Contributor

Can we try again uncommenting those lines that @estemendoza says?

@estemendoza
Copy link

Hi @w0rmr1d3r, I tried enabling those lines and now they show up on the report, but they always show as "Unspecified", no matter what check I execute, so I think that doesn't solve the issue

@w0rmr1d3r
Copy link
Contributor

Let's try another thing, can you try running Prowler, but without specific checks? Just with a group.
For instance, execute Prowler so it runs the whole IAM group and the output is csv. With those lines enabled!

Can you try that and tell us what does appear?

Thank you @estemendoza !

@estemendoza
Copy link

@w0rmr1d3r No problem, executed the following command: ./prowler -g group1 -M csv and same result

Screenshot 2021-08-18 at 17 10 59

@toniblyx
Copy link
Member

hey guys! My bad, I should have included that information in the release notes, sorry about that. I removed those fields because are only used by CIS checks, and now Prowler is way more than just CIS checks. The plan is to have another way to identify checks that belong to a particular standard or framework. If you think Scored/Not Scored and Level is really important for you, please let me know.

@CenturionGamer
Copy link
Contributor Author

@toniblyx - Hey man! Thanks for the reply. I'll connect with @estemendoza and see how relevant those columns are, and if we need them.

@snotrauk
Copy link
Contributor

The level is important for the CIS checks IMO. Would rather that stayed.

@toniblyx
Copy link
Member

@shaunography yes, I kind of agree for CIS checks only. The plan is to change the way checks are related to security frameworks and regulations so that will change but the implementation is not clear yet in terms of checks metadata.

@toniblyx
Copy link
Member

toniblyx commented Nov 8, 2021

Hey @shaunography @estemendoza @CenturionGamer @w0rmr1d3r,

This will come back in version 3 with the reachitecture of checks and implementation of compliance related information per check. Item scored won't be included but CIS Level will.

@toniblyx toniblyx closed this as completed Nov 8, 2021
@eprothro
Copy link

eprothro commented Nov 9, 2021

I agree keeping the CIS level / scored fields -- at least until there is a replacement available. Our compliance review requires being able to report on (and thus filter by) CIS Scored checks by level. Since these fields were removed with any kind of replacement we can't use the current version.

@toniblyx
Copy link
Member

Watch out! I have added back CIS Level to the 2.5.1 branch that will be merged to master soon. It's added to CSV, HTML and JSON outputs.

@toniblyx
Copy link
Member

Now this one can be closed :D

@toniblyx
Copy link
Member

Screenshot 2021-11-11 at 13 37 55

@eprothro
Copy link

Thank you for the quick consideration!

@toniblyx
Copy link
Member

You are welcome, it is actually in branch 2.6, this has many changes and fixes that deserves a minor version instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants