-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ITEM_SCORED and ITEM_LEVEL in csv #848
Comments
Hello @CenturionGamer ! Thanks! |
I am no good with Bash, but could this be the issue? These lines are commented out |
@w0rmr1d3r - Good morning! Thanks for responding to this issue. See the comment above from @estemendoza and the code he posted. I ran Prowler the same way as @estemendoza did. |
Can we try again uncommenting those lines that @estemendoza says? |
Hi @w0rmr1d3r, I tried enabling those lines and now they show up on the report, but they always show as "Unspecified", no matter what check I execute, so I think that doesn't solve the issue |
Let's try another thing, can you try running Prowler, but without specific checks? Just with a group. Can you try that and tell us what does appear? Thank you @estemendoza ! |
@w0rmr1d3r No problem, executed the following command: |
hey guys! My bad, I should have included that information in the release notes, sorry about that. I removed those fields because are only used by CIS checks, and now Prowler is way more than just CIS checks. The plan is to have another way to identify checks that belong to a particular standard or framework. If you think Scored/Not Scored and Level is really important for you, please let me know. |
@toniblyx - Hey man! Thanks for the reply. I'll connect with @estemendoza and see how relevant those columns are, and if we need them. |
The level is important for the CIS checks IMO. Would rather that stayed. |
@shaunography yes, I kind of agree for CIS checks only. The plan is to change the way checks are related to security frameworks and regulations so that will change but the implementation is not clear yet in terms of checks metadata. |
Hey @shaunography @estemendoza @CenturionGamer @w0rmr1d3r, This will come back in version 3 with the reachitecture of checks and implementation of compliance related information per check. Item scored won't be included but CIS Level will. |
I agree keeping the CIS level / scored fields -- at least until there is a replacement available. Our compliance review requires being able to report on (and thus filter by) CIS Scored checks by level. Since these fields were removed with any kind of replacement we can't use the current version. |
Watch out! I have added back CIS Level to the 2.5.1 branch that will be merged to master soon. It's added to CSV, HTML and JSON outputs. |
Now this one can be closed :D |
Thank you for the quick consideration! |
You are welcome, it is actually in branch 2.6, this has many changes and fixes that deserves a minor version instead. |
ITEM_SCORED and ITEM_LEVEL are both blank in the results. This happened for multiple checks.
The text was updated successfully, but these errors were encountered: