fix(extra730): Handle invalid date formats checking ACM certificates #1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfagoagas
commented
Feb 7, 2022
Comment on lines
-37
to
-39
| if [[ $1 = 20* ]];then | ||
| echo $1 | cut -f1 -d"T" | ||
| else |
There was a problem hiding this comment.
I've deleted this date parsing because it allows something like 20wathever
toniblyx
requested changes
Feb 8, 2022
| # "Check if ACM Certificates are about to expire in $DAYS_TO_EXPIRE_THRESHOLD days or less" | ||
| for regx in $REGIONS; do | ||
| LIST_OF_ACM_CERTS=$($AWSCLI acm list-certificates $PROFILE_OPT --region $regx --query 'CertificateSummaryList[].CertificateArn' --output text) | ||
| if [[ $LIST_OF_ACM_CERTS ]];then | ||
| LIST_OF_ACM_CERTS=$("${AWSCLI}" acm list-certificates ${PROFILE_OPT} --region "${regx}" --include keyTypes="${ACM_KEY_TYPES}" --certificate-statuses "${ACM_CERTIFICATE_STATUSES}" --query 'CertificateSummaryList[].CertificateArn' --output text) |
There was a problem hiding this comment.
What about imported certificates?
There was a problem hiding this comment.
It checks every ACM certificate whether it is Amazon Issued, Imported or comes from a Private PKI.
For that reason we have included two filters:
ACM_KEY_TYPES: to set the algorithms that can be used to generate key pairs.ACM_CERTIFICATE_STATUSES: to only check ACM Certificates whose status isISSUED. The following statuses are not checked:
PENDING_VALIDATION
INACTIVE
EXPIRED
VALIDATION_TIMED_OUT
REVOKED
FAILED
jfagoagas
commented
Feb 8, 2022
Comment on lines
-49
to
-51
| if [[ $1 = 20* ]];then | ||
| echo $1 | cut -f1 -d"T" | ||
| else |
There was a problem hiding this comment.
I've deleted this date parsing because it allows something like 20wathever
n4ch04
reviewed
Feb 9, 2022
| # remove fractions of a second | ||
| TIMESTAMP_TO_CONVERT=$(cut -f1 -d"." <<< "${1}") | ||
| OUTPUT_DATE=$("${DATE_CMD}" -d @"${TIMESTAMP_TO_CONVERT}" +'%Y-%m-%d') | ||
| echo "${OUTPUT_DATE}" |
There was a problem hiding this comment.
Yes, it's the way to return the OUTPUT_DATE value
n4ch04
approved these changes
Feb 9, 2022
toniblyx
approved these changes
Feb 9, 2022
jfagoagas
deleted the
PRWLR-15-bug-extra-730-acm-certificates-date-validation
branch
jfagoagas
removed
the
status/waiting-for-revision
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
extra730 checks if ACM Certificates are about to expire in
$DAYS_TO_EXPIRE_THRESHOLDdays or lessDescription
This PR addresses the following:
bsd_timestamp_to_dateandgnu_timestamp_to_datein order to perform date validation properly.License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.