Added timestamp to temp folders for secrets related checks #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfagoagas
added
severity/medium
toniblyx
changed the title
toniblyx
approved these changes
Mar 2, 2022
|
Thanks @sectoramen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Added a timestamp to the checks. When running prowler in parallel for multiple zones, the SECRETS_TEMP_FOLDER file is overwritten"
Description
The five checks have been changed to include a timestamp in the file name to avoid race conditions:
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.