Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(extra760): Improve error handling #1055

Merged
merged 8 commits into from
Mar 16, 2022
Merged

fix(extra760): Improve error handling #1055

merged 8 commits into from
Mar 16, 2022

Conversation

lazize
Copy link
Contributor

@lazize lazize commented Mar 4, 2022

Context

This check was not handling curl failures.

Description

Improved error handling for curl.
Fix issue #1014

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lazize lazize requested review from a team, toniblyx, jfagoagas and n4ch04 March 4, 2022 13:45
jfagoagas
jfagoagas requested changes Mar 8, 2022
View reviewed changes
@jfagoagas jfagoagas added severity/medium Results in some unexpected or undesired behavior. status/waiting-for-revision Waiting for maintainer's revision labels Mar 8, 2022
@jfagoagas jfagoagas changed the title Fix extra760 fix(extra760): Improve error handling Mar 8, 2022
@n4ch04 n4ch04 requested a review from jfagoagas March 14, 2022 11:57
jfagoagas
jfagoagas requested changes Mar 15, 2022
View reviewed changes
Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @lazize, please check our comments to merge this.

Thanks!!

@jfagoagas jfagoagas added status/awaiting-reponse Waiting response from Issue owner and removed status/waiting-for-revision Waiting for maintainer's revision labels Mar 15, 2022
@lazize
Copy link
Contributor Author

lazize commented Mar 15, 2022

@jfagoagas Please, check my comments

@jfagoagas
Copy link
Member

@jfagoagas Please, check my comments

Reviewed, thank you!

jfagoagas
jfagoagas requested changes Mar 16, 2022
View reviewed changes
Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, check grep -q comments.

Thanks!!

@jfagoagas jfagoagas self-requested a review March 16, 2022 12:21
jfagoagas
jfagoagas requested changes Mar 16, 2022
View reviewed changes
@jfagoagas jfagoagas self-requested a review March 16, 2022 12:32
jfagoagas
jfagoagas requested changes Mar 16, 2022
View reviewed changes
@jfagoagas jfagoagas self-requested a review March 16, 2022 13:56
@jfagoagas jfagoagas removed the status/awaiting-reponse Waiting response from Issue owner label Mar 16, 2022
jfagoagas
jfagoagas approved these changes Mar 16, 2022
View reviewed changes
Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @lazize

Awesome job!! 👏 👏 👏 👏

@jfagoagas jfagoagas merged commit c4aff56 into prowler-cloud:master Mar 16, 2022
@jfagoagas jfagoagas mentioned this pull request Mar 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfagoagas jfagoagas jfagoagas approved these changes

@toniblyx toniblyx Awaiting requested review from toniblyx

@n4ch04 n4ch04 Awaiting requested review from n4ch04

Assignees
No one assigned
Labels
severity/medium Results in some unexpected or undesired behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lazize @jfagoagas