Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(detect-secrets): Include missing colon to link values #1078

Merged
merged 1 commit into from
Mar 22, 2022

Conversation

jfagoagas
Copy link
Member

@jfagoagas jfagoagas commented Mar 18, 2022

Context

extra742 uses detect-secrets to find possible secret values within strings or whole files.

Description

Right now, this checks passes to detect-secrets the following values extracted from CloudFormation Stack Outputs:

Output1 Value1
Output2 Value2
Output3 Value3

The problem is that detect-secrets can't link output values with their related values.

Screenshot 2022-03-18 at 13 35 35

To fix this we've included a : to link values:

Output1:Value1
Output2:Value2
Output3:Value3

Screenshot 2022-03-18 at 13 36 00

With that detect-secrets can identify possible secrets.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Member

@MrCloudSec MrCloudSec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, great job 💪

@MrCloudSec MrCloudSec merged commit 5652005 into master Mar 22, 2022
@MrCloudSec MrCloudSec deleted the PRWLR-239-fix-cfn-output-secrets branch March 22, 2022 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants