Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(extra764): Deleted temporary file references #1089

Conversation

n4ch04
Copy link
Contributor

@n4ch04 n4ch04 commented Mar 30, 2022

Context

There were references to a temporary file in check extra764 that is not currently needed and shared name with the variable that stores the content of the bucket policy. At the time of deleting the temporary file an error was generated due to trying to delete the content of the variable

Description

All the temporary file references in check extra764 have been deleted

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@n4ch04 n4ch04 requested review from a team, toniblyx, jfagoagas and MrCloudSec March 30, 2022 07:52
jfagoagas
jfagoagas previously approved these changes Mar 30, 2022
Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!!!

@n4ch04 n4ch04 changed the title fix(extra764): Deleted temp file refs NO MERGE. --- fix(extra764): Deleted temp file refs Mar 30, 2022
MrCloudSec
MrCloudSec previously approved these changes Mar 30, 2022
Copy link
Member

@MrCloudSec MrCloudSec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job!

@jfagoagas jfagoagas changed the title NO MERGE. --- fix(extra764): Deleted temp file refs [NO MERGE] fix(extra764): Deleted temp file refs Mar 31, 2022
@jfagoagas jfagoagas changed the title [NO MERGE] fix(extra764): Deleted temp file refs [NO MERGE] fix(extra764): Deleted temporary file references Mar 31, 2022
@jfagoagas jfagoagas dismissed stale reviews from MrCloudSec and themself via 8db6c83 March 31, 2022 13:45
@jfagoagas jfagoagas self-requested a review April 7, 2022 15:03
Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go!

@jfagoagas jfagoagas changed the title [NO MERGE] fix(extra764): Deleted temporary file references fix(extra764): Deleted temporary file references Apr 7, 2022
@jfagoagas jfagoagas merged commit 07b2b0d into master Apr 7, 2022
@jfagoagas jfagoagas deleted the PRWLR-183-bug-failing-to-send-check-output-to-aws-security-hub-due-to-wrong-region branch April 7, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants