feat(S3_in_w_x_flags): Support S3 URIs for custom checks paths and whitelist files. #1090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toniblyx
requested changes
Mar 31, 2022
Co-authored-by: Toni de la Fuente <[email protected]>
MrCloudSec
force-pushed
the
PRWLR-317-allow-prowler-to-get-whitelist-files-and-custom-checks-from-s-3
branch
from
a8f91a4 to
031049b
Compare
jfagoagas
requested changes
Mar 31, 2022
Co-authored-by: Toni de la Fuente <[email protected]>
MrCloudSec
force-pushed
the
PRWLR-317-allow-prowler-to-get-whitelist-files-and-custom-checks-from-s-3
branch
from
031049b to
a0f5b1f
Compare
|
Do we need to include required AWS S3 API permissions? |
Review the last commit with those changes pls. |
jfagoagas
approved these changes
Mar 31, 2022
toniblyx
deleted the
PRWLR-317-allow-prowler-to-get-whitelist-files-and-custom-checks-from-s-3
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This new feature will allow users to input S3 URIs when working with whitelists (-w flag) or custom checks paths (-x flag).
Description
If an user input a S3 URI in flags -w or -x, Prowler will automatically read the files from the indicated S3 bucket.
For example:
./prowler -c extra764 -p <profile_name> -w s3://bucket/whitelist.txt
./prowler -c extra764 -p <profile_name> -x s3://bucket/checks
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.