Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(extra764): NoSuchBucket error properly handled. #1094

Conversation

MrCloudSec
Copy link
Member

Context

NoSuchBucket error was not handled in this check.

Description

The error NoSuchBucket is now properly handled as well as unknown errors.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@MrCloudSec MrCloudSec requested review from a team, toniblyx, jfagoagas and n4ch04 March 31, 2022 09:55
Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, review above comments. Also include ${REGION}" "${bucket}" in lines 50 and 55

@MrCloudSec MrCloudSec requested a review from jfagoagas March 31, 2022 12:51
Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @sergargar !!

@jfagoagas jfagoagas merged commit 734331d into master Mar 31, 2022
@jfagoagas jfagoagas deleted the PRWLR-315-check-extra-764-needs-to-handle-better-s-3-api-errors branch March 31, 2022 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants