fix(kms): call GetKeyRotationStatus only for Customer Keys #1842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfagoagas
requested changes
Feb 6, 2023
| @@ -73,7 +73,7 @@ def __get_key_rotation_status__(self): | |||
| logger.info("KMS - Get Key Rotation Status...") | |||
| for key in self.keys: | |||
| try: | |||
| if "EXTERNAL" not in key.origin: | |||
| if "EXTERNAL" not in key.origin and "AWS" not in key.manager: | |||
There was a problem hiding this comment.
Suggested change
| if "EXTERNAL" not in key.origin and "AWS" not in key.manager: | |
| if "EXTERNAL" not in key.origin and key.manager == "CUSTOMER": |
I prefer to set CUSTOMER. What do you think?
There was a problem hiding this comment.
The output would be the same, so I prefer leaving it as it is.
…ils-for-aws-managed-kms-keys-used-by-acm
jfagoagas
approved these changes
Feb 6, 2023
MrCloudSec
deleted the
1838-bug-kms_cmk_rotation_enabled-check-fails-for-aws-managed-kms-keys-used-by-acm
branch
MrCloudSec
added a commit
that referenced
this pull request
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Regarding #1838, solve the following error:
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.