chore(compliance): add manual checks to compliance CSV #1872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfagoagas
requested changes
Feb 10, 2023
| @@ -41,6 +43,64 @@ def update_checks_metadata_with_compliance( | |||
| check_compliance.append(compliance) | |||
| # Save it into the check's metadata | |||
| bulk_checks_metadata[check].Compliance = check_compliance | |||
|
|
|||
| # Add requirements of Manual Controls | |||
| for framework in bulk_compliance_frameworks.values(): | |||
There was a problem hiding this comment.
why are you doing the same for again here?
You can use the one above.
There was a problem hiding this comment.
Because the one above is iterating for each check and it has to be only done once.
jfagoagas
previously approved these changes
Feb 10, 2023
MrCloudSec
force-pushed
the
PRWLR-1503-add-manual-compliance-controls-to-csv
branch
from
64575b0 to
2e01bde
Compare
MrCloudSec
deleted the
PRWLR-1503-add-manual-compliance-controls-to-csv
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add manual checks to compliances' CSV.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.