fix(services): solve errors in EMR, RDS, S3 and VPC services #1913
Conversation
MrCloudSec
changed the title
| @@ -54,7 +54,7 @@ def __describe_db_instances__(self, regional_client): | |||
| self.db_instances.append( | |||
| DBInstance( | |||
| id=instance["DBInstanceIdentifier"], | |||
| endpoint=instance["Endpoint"]["Address"], | |||
| endpoint=instance.get("Endpoint"), | |||
There was a problem hiding this comment.
Why are you retrieving the Endpoint dict if you need the Address in the check?
There was a problem hiding this comment.
Because endpoint is a dictionary that contains the address and the port.
| try: | ||
| regional_client = self.regional_clients[bucket.region] | ||
| except Exception as error: | ||
| logger.error( | ||
| f"{error.__class__.__name__}[{error.__traceback__.tb_lineno}]: {error}" | ||
| ) | ||
| try: |
There was a problem hiding this comment.
Why do you need two try blocks?
There was a problem hiding this comment.
Because the first try does not have the regional_client defined and the second one has it.
| except Exception as error: | ||
| logger.error( | ||
| f"{error.__class__.__name__}[{error.__traceback__.tb_lineno}]: {error}" | ||
| ) | ||
| try: |
There was a problem hiding this comment.
Why do you need two try blocks?
There was a problem hiding this comment.
Because the first try does not have the regional_client defined and the second one has it.
MrCloudSec
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if ".amazonaws.com" in master_public_dns_name: | ||
| if ( | ||
| master_public_dns_name | ||
| and ".amazonaws.com" in master_public_dns_name |
Check failure
Code scanning / CodeQL
Incomplete URL substring sanitization
Description
Solve errors in S3 and VPC services:
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.