feat(s3_bucket_level_public_access_block): new check #1953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n4ch04
approved these changes
Mar 2, 2023
addefisher
reviewed
Mar 8, 2023
| @@ -533,7 +533,7 @@ | |||
| "Id": "2.1.5", | |||
| "Description": "Ensure that S3 Buckets are configured with 'Block public access (bucket settings)'", | |||
| "Checks": [ | |||
| "s3_account_level_public_access_blocks" | |||
| "s3_bucket_level_public_access_block" | |||
There was a problem hiding this comment.
While I requested this check, I do not think it should be added to the CIS compliance file. Generally account level BPA settings are a better way to achieve CIS compliance. The s3_bucket_level_public_access_block check is extremely useful for edge cases (where an account has a legitimate need for a public bucket and a risk exception has been made), but the account level checks are a preferable approach for most environments / AWS accounts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Regarding #1916, add new check that complies with CIS control 2.1.5.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.