-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rds_instance_transport_encrypted): add new check #1963
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks to @Fennerr for the idea!
...viders/aws/services/rds/rds_instance_transport_encrypted/rds_instance_transport_encrypted.py
Outdated
Show resolved
Hide resolved
...viders/aws/services/rds/rds_instance_transport_encrypted/rds_instance_transport_encrypted.py
Outdated
Show resolved
Hide resolved
...services/rds/rds_instance_transport_encrypted/rds_instance_transport_encrypted.metadata.json
Outdated
Show resolved
Hide resolved
...services/rds/rds_instance_transport_encrypted/rds_instance_transport_encrypted.metadata.json
Outdated
Show resolved
Hide resolved
...services/rds/rds_instance_transport_encrypted/rds_instance_transport_encrypted.metadata.json
Outdated
Show resolved
Hide resolved
...services/rds/rds_instance_transport_encrypted/rds_instance_transport_encrypted.metadata.json
Outdated
Show resolved
Hide resolved
...services/rds/rds_instance_transport_encrypted/rds_instance_transport_encrypted.metadata.json
Outdated
Show resolved
Hide resolved
Just moving across the info from the slack chat I had with Sergio to here: For Oracle databases the rds client also needs to retrieve the option groups, and then check for the SQLNET.SSL_VERSION option to that group. https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/Appendix.Oracle.Options.SSL.html#Appendix.Oracle.Options.SSL.OptionGroup
The check can also check if it is set to use TLS 1.0
I can add this to the current check, or it can be a separate check |
…ypted/rds_instance_transport_encrypted.metadata.json Co-authored-by: Toni de la Fuente <[email protected]>
...services/rds/rds_instance_transport_encrypted/rds_instance_transport_encrypted.metadata.json
Outdated
Show resolved
Hide resolved
Co-authored-by: Toni de la Fuente <[email protected]>
@Fennerr, this is a great idea, it would be awesome if you can do it, we have include it in our roadmap anyway. |
Description
Add new check called
rds_instance_transport_encrypted
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.