fix(acm): Fix issues with list-certificates #1970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfagoagas
requested review from
a team,
drewkerrigan,
thejaywhy and
toniblyx
jfagoagas
requested review from
n4ch04 and
MrCloudSec
and removed request for
drewkerrigan and
thejaywhy
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
There was an issue with the ACM service since we were retrieving the certificate data from the
describe_certificateinstead of thelist_certificatesand in the case of a Bad Request error from AWS the above checks were failing.Description
acm_certificates_expiration_check -- AttributeError[13]: 'Certificate' object has no attribute 'expiration_days'acm_certificates_transparency_logs_enabled -- AttributeError[11]: 'Certificate' object has no attribute 'type'Also I've fixed a flaky test from TrustedAdvisor since in some cases the AWS Region was not present in the client.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.