Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(s3): handle if ignore_public_acls is None #2128

Conversation

jfagoagas
Copy link
Member

@jfagoagas jfagoagas commented Mar 24, 2023

Description

Fix the following error: s3_bucket_level_public_access_block -- AttributeError[19]: 'NoneType' object has no attribute 'ignore_public_acls'

Also I've fixed the pre-commit not to run for the poetry.lock and mocked the request from the check_current_version test.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jfagoagas jfagoagas requested a review from a team March 24, 2023 10:33
@jfagoagas jfagoagas force-pushed the PRWLR-1827-prowler-fix-attribute-error-19-none-type-object-has-no-attribute-ignore-public-acls branch from 6c8261a to 51bf6f4 Compare March 24, 2023 10:37
MrCloudSec
MrCloudSec previously approved these changes Mar 24, 2023
Copy link
Member

@MrCloudSec MrCloudSec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@jfagoagas jfagoagas requested a review from MrCloudSec March 27, 2023 14:50
Copy link
Member

@MrCloudSec MrCloudSec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔝 🔝 🔝

@MrCloudSec MrCloudSec merged commit 0d16880 into master Mar 27, 2023
@MrCloudSec MrCloudSec deleted the PRWLR-1827-prowler-fix-attribute-error-19-none-type-object-has-no-attribute-ignore-public-acls branch March 27, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants