Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(test): mock VPC client #2640

Merged
merged 1 commit into from
Jul 31, 2023
Merged

fix(test): mock VPC client #2640

merged 1 commit into from
Jul 31, 2023

Conversation

jfagoagas
Copy link
Member

Description

Fix the flaky test test_vpc_without_flow_logs and test_vpc_with_flow_logs.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jfagoagas jfagoagas requested a review from a team July 31, 2023 08:46
@jfagoagas jfagoagas changed the title fix: mock VPC client fix(test): mock VPC client Jul 31, 2023
@jfagoagas jfagoagas self-assigned this Jul 31, 2023
@jfagoagas jfagoagas added the provider/aws Issues/PRs related with the AWS provider label Jul 31, 2023
MrCloudSec
MrCloudSec approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@MrCloudSec MrCloudSec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏼

@MrCloudSec MrCloudSec merged commit b4e78d2 into master Jul 31, 2023
@MrCloudSec MrCloudSec deleted the PRWLR-2385-prowler-fix-the-flaky-test-test-vpc-without-flow-logs-and-test-vpc-with-flow-logs branch July 31, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrCloudSec MrCloudSec MrCloudSec approved these changes

Assignees

@jfagoagas jfagoagas

Labels
provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jfagoagas @MrCloudSec