Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(s3): Move lib to the AWS provider and include tests #2664

Conversation

jfagoagas
Copy link
Member

Description

Move s3 lib to the AWS provider and include tests.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jfagoagas jfagoagas requested a review from a team August 2, 2023 13:41
@jfagoagas jfagoagas self-assigned this Aug 2, 2023
@jfagoagas jfagoagas added the provider/aws Issues/PRs related with the AWS provider label Aug 2, 2023
@jfagoagas jfagoagas force-pushed the PRWLR-2397-prowler-move-send-to-s-3-bucket-function-to-the-aws-provider branch from 4f194ba to e0b5386 Compare August 14, 2023 06:09
@jfagoagas jfagoagas force-pushed the PRWLR-2397-prowler-move-send-to-s-3-bucket-function-to-the-aws-provider branch from e0b5386 to 7e9712f Compare August 21, 2023 08:51
@jfagoagas jfagoagas force-pushed the PRWLR-2397-prowler-move-send-to-s-3-bucket-function-to-the-aws-provider branch from ee475c6 to a94f6bb Compare August 23, 2023 08:13
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #2664 (14f2f6d) into master (d186c69) will increase coverage by 0.10%.
Report is 14 commits behind head on master.
The diff coverage is 73.52%.

@@            Coverage Diff             @@
##           master    #2664      +/-   ##
==========================================
+ Coverage   86.13%   86.24%   +0.10%     
==========================================
  Files         527      537      +10     
  Lines       17080    17266     +186     
==========================================
+ Hits        14712    14891     +179     
- Misses       2368     2375       +7     
Files Changed Coverage Δ
prowler/__main__.py 0.00% <0.00%> (ø)
prowler/providers/aws/lib/s3/s3.py 77.41% <77.41%> (ø)
prowler/lib/outputs/outputs.py 44.03% <100.00%> (-5.97%) ⬇️

... and 17 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jfagoagas jfagoagas merged commit cb76e5a into master Aug 23, 2023
@jfagoagas jfagoagas deleted the PRWLR-2397-prowler-move-send-to-s-3-bucket-function-to-the-aws-provider branch August 23, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants