Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(azure): Improve AzureService class with __set_clients__ #2676

Merged
merged 1 commit into from
Aug 4, 2023
Merged

chore(azure): Improve AzureService class with __set_clients__ #2676

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 25 additions & 5 deletions prowler/providers/azure/lib/service/service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,28 @@
from prowler.lib.logger import logger


class AzureService:
def __init__(self, service, audit_info):
# We receive the service using __class__.__name__ or the service name in lowercase
# e.g.: Storage --> we need a lowercase string, so service.lower()
self.service = service.lower() if not service.islower() else service
def __init__(
self,
service,
audit_info,
):
self.clients = self.__set_clients__(
audit_info.identity.subscriptions, audit_info.credentials, service
)

self.credentials = audit_info.credentials
self.subscriptions = audit_info.identity.subscriptions

def __set_clients__(self, subscriptions, credentials, service):
clients = {}
try:
for display_name, id in subscriptions.items():
clients.update(
{display_name: service(credential=credentials, subscription_id=id)}
)
except Exception as error:
logger.error(
f"{error.__class__.__name__}[{error.__traceback__.tb_lineno}]: {error}"
)
else:
return clients
23 changes: 1 addition & 22 deletions prowler/providers/azure/services/defender/defender_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,31 +10,10 @@
########################## Defender
class Defender(AzureService):
def __init__(self, audit_info):
super().__init__(__class__.__name__, audit_info)
super().__init__(SecurityCenter, audit_info)

self.clients = self.__set_clients__(
audit_info.identity.subscriptions, audit_info.credentials
)
self.pricings = self.__get_pricings__()

def __set_clients__(self, subscriptions, credentials):
clients = {}
try:
for display_name, id in subscriptions.items():
clients.update(
{
display_name: SecurityCenter(
credential=credentials, subscription_id=id
)
}
)
except Exception as error:
logger.error(
f"{error.__class__.__name__}[{error.__traceback__.tb_lineno}]: {error}"
)
else:
return clients

def __get_pricings__(self):
logger.info("Defender - Getting pricings...")
pricings = {}
Expand Down
23 changes: 1 addition & 22 deletions prowler/providers/azure/services/iam/iam_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,30 +10,9 @@
########################## IAM
class IAM(AzureService):
def __init__(self, audit_info):
super().__init__(__class__.__name__, audit_info)
self.clients = self.__set_clients__(
audit_info.identity.subscriptions, audit_info.credentials
)
super().__init__(AuthorizationManagementClient, audit_info)
self.roles = self.__get_roles__()

def __set_clients__(self, subscriptions, credentials):
clients = {}
try:
for display_name, id in subscriptions.items():
clients.update(
{
display_name: AuthorizationManagementClient(
credential=credentials, subscription_id=id
)
}
)
except Exception as error:
logger.error(
f"{error.__class__.__name__}[{error.__traceback__.tb_lineno}]: {error}"
)
else:
return clients

def __get_roles__(self):
logger.info("IAM - Getting roles...")
roles = {}
Expand Down
23 changes: 1 addition & 22 deletions prowler/providers/azure/services/sqlserver/sqlserver_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,30 +14,9 @@
########################## SQLServer
class SQLServer(AzureService):
def __init__(self, audit_info):
super().__init__(__class__.__name__, audit_info)
self.clients = self.__set_clients__(
audit_info.identity.subscriptions, audit_info.credentials
)
super().__init__(SqlManagementClient, audit_info)
self.sql_servers = self.__get_sql_servers__()

def __set_clients__(self, subscriptions, credentials):
clients = {}
try:
for display_name, id in subscriptions.items():
clients.update(
{
display_name: SqlManagementClient(
credential=credentials, subscription_id=id
)
}
)
except Exception as error:
logger.error(
f"{error.__class__.__name__}[{error.__traceback__.tb_lineno}]: {error}"
)
else:
return clients

def __get_sql_servers__(self):
logger.info("SQL Server - Getting SQL servers...")
sql_servers = {}
Expand Down
23 changes: 1 addition & 22 deletions prowler/providers/azure/services/storage/storage_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,30 +10,9 @@
########################## Storage
class Storage(AzureService):
def __init__(self, audit_info):
super().__init__(__class__.__name__, audit_info)
self.clients = self.__set_clients__(
audit_info.identity.subscriptions, audit_info.credentials
)
super().__init__(StorageManagementClient, audit_info)
self.storage_accounts = self.__get_storage_accounts__()

def __set_clients__(self, subscriptions, credentials):
clients = {}
try:
for display_name, id in subscriptions.items():
clients.update(
{
display_name: StorageManagementClient(
credential=credentials, subscription_id=id
)
}
)
except Exception as error:
logger.error(
f"{error.__class__.__name__}[{error.__traceback__.tb_lineno}]: {error}"
)
else:
return clients

def __get_storage_accounts__(self):
logger.info("Storage - Getting storage accounts...")
storage_accounts = {}
Expand Down